-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Case insensitive file name matching when packaging files #13885
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @epage (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Note that #13722 is not marked as S-Accepted. I don't think we've come to a conclusion on if it should be fixed and what the right constraints are. |
I am now noticing that Cargo uses the use unicase::Ascii as UncasedAscii; This PR should do that rather than explicitly converting to lowercase and comparing. |
Thanks for the PR. Marked it as draft for now to reflect the fact that it's still in discussion. |
☔ The latest upstream changes (presumably #14004) made this pull request unmergeable. Please resolve the merge conflicts. |
Fixes #13722.
Handles the readme and license files. The
Cargo.lock
file is trickier. There are a bunch of places in the code where the existence ofCargo.lock
(case sensitive) is checked, including when packaging.I think it should be OK to keep
Cargo.lock
out of this. While the readme and license files are typically created by the user, theCargo.lock
file is typically created by Cargo, hence casing should be consistent anyway.This PR also doesn't handle a
TARGET
dir. I can look into that if desired.#13722 (comment)