Add more documentation to cargo::rustc-check-cfg
#13869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-documenting-cargo-itself
weihanglo
reviewed
May 6, 2024
| @@ -288,6 +292,7 @@ if foo_bar_condition { | |||
| } | |||
There was a problem hiding this comment.
Unrelated to this PR. Instead of putting an example here, do you think it's better to just have a link to the conditional compilation build script example?
There was a problem hiding this comment.
I think having a example right in the documentation is very valuable, however linking to a more complete example is quite valuable to, so I added a link to it.
weihanglo
approved these changes
May 6, 2024
|
@bors r+ Thanks! |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 8, 2024
Update cargo 10 commits in 05364cb2f61a2c2b091e061c1f42b207dfb5f81f..0ca60e940821c311c9b25a6423b59ccdbcea218f 2024-05-03 16:48:59 +0000 to 2024-05-08 01:54:25 +0000 - chore: Add cargo-lints to unstable docs (rust-lang/cargo#13881) - test: clean up unnecessary uses of `match_exact` (rust-lang/cargo#13879) - docs(ref): Correct heading level of `[lints]` documentation (rust-lang/cargo#13878) - Fix: Build only the specified artifact library when multiple types are available (rust-lang/cargo#13842) - docs: add missing CARGO_MAKEFLAGS env for plugins (rust-lang/cargo#13872) - Add more documentation to `cargo::rustc-check-cfg` (rust-lang/cargo#13869) - fix(toml): Remove unstable rejrected frontmatter syntax for cargo script (rust-lang/cargo#13861) - Update UI example code in contributor guide (rust-lang/cargo#13864) - style(test): Remove check-cfg warning (rust-lang/cargo#13865) - Fix global_cache_tracker::max_download_size test flakiness (rust-lang/cargo#13860) r? ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add more documentation to
cargo::rustc-check-cfgby:cargo:rustc-check-cfgfor MSRVcargo::rustc-cfgandcargo::rustc-check-cfgis displayedFixes #13868
r? @weihanglo