Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toml)!: Remove support for inheriting badges #13788

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Commits on Apr 22, 2024

  1. fix(toml)!: Remove support for inheriting badges

    We allowed `[badges]` to inherit from `[workspace.package.badges]`
    
    This was a bug:
    - This was not specified in the RFC
    - We did not document this
    - Even if someone were to try to guess to use this, it is inconsistent
      with how inheritance works because this should inherit from
      `workspace.badges` instead of `workspace.package.badges`
    
    While keeping in mind that `[badges]` is effectively deprecated.
    
    In that context, I think its safe to break support for this without a
    transition period.
    
    Fixes rust-lang#13643
    epage committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    bdd4bda View commit details
    Browse the repository at this point in the history