New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust root package page content #13725

Closed

heisen-li wants to merge 2 commits into rust-lang:master from heisen-li:workspace_doc

Contributor

heisen-li commented Apr 9, 2024 •

edited

Loading

What does this PR try to resolve?

part of #13580

explain the behavior of a root package

added a description in the root package section of the workspace page of root package becoming the default member when no workspace member is specified.
repositioned the definition of workspace root so that the definition itself appears where workspace root is first mentioned.

rustbot assigned ehuss

Collaborator

rustbot commented Apr 9, 2024

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added A-documenting-cargo-itself S-waiting-on-review labels

epage reviewed

View reviewed changes

src/doc/src/reference/workspaces.md Outdated Show resolved Hide resolved

epage reviewed

View reviewed changes

src/doc/src/reference/workspaces.md Outdated Show resolved Hide resolved

epage reviewed

View reviewed changes

src/doc/src/reference/workspaces.md Outdated Show resolved Hide resolved

epage reviewed

View reviewed changes

src/doc/src/reference/workspaces.md Outdated Show resolved Hide resolved

heisen-li changed the title ~~Improve Workspaces docs page~~ Adjust root package page content

heisen-li marked this pull request as ready for review

April 10, 2024 03:26

heisen-li mentioned this pull request

Improve Workspaces docs page #13580

Open

epage reviewed

View reviewed changes

src/doc/src/reference/workspaces.md Outdated Show resolved Hide resolved

Contributor Author

heisen-li commented Apr 21, 2024

Sorry. Are there any other changes suggested?

weihanglo reviewed

View reviewed changes

Member

weihanglo left a comment

Thanks for the doc update.
Could you rework on Git commits in a reasonable manner? Some intermediate commits like “merge master” shouldn't be here.

src/doc/src/reference/workspaces.md Outdated Show resolved Hide resolved

src/doc/src/reference/workspaces.md Outdated Show resolved Hide resolved

src/doc/src/reference/workspaces.md Outdated Show resolved Hide resolved

src/doc/src/reference/workspaces.md Outdated Show resolved Hide resolved

Contributor

epage commented Apr 23, 2024

@heisen-li I talked the challenge of writing this section with @weihanglo and had an idea on how to cover this topic. What are your thoughts on #13794?

ehuss and others added 2 commits

April 24, 2024 10:48


          Fix github fast path redirect.

686e3e8


          Improve Workspaces docs page

a260a4c

heisen-li force-pushed the workspace_doc branch from aad3a1b to a260a4c Compare

April 24, 2024 02:50

rustbot added A-cli A-cli-help A-completions A-git A-rebuild-detection Command-add labels

heisen-li closed this

heisen-li deleted the workspace_doc branch

April 24, 2024 02:54

heisen-li mentioned this pull request

Improve Workspaces docs page #13796

Closed

Contributor Author

heisen-li commented Apr 24, 2024

@heisen-li I talked the challenge of writing this section with @weihanglo and had an idea on how to cover this topic. What are your thoughts on #13794?

I think it's fine, no other suggestions. I'll update the #13766 parser section a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli A-cli-help A-completions A-documenting-cargo-itself A-git A-rebuild-detection Command-add S-waiting-on-review