Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: comments on PackageRegistry #13698

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

weihanglo
Copy link
Member

What does this PR try to resolve?

Doc comments and intra-doc links for PackageRegistry struct.

How should we test and review this PR?

cargo doc --document-private-items --no-deps

And proofread.

Additional information

Okay. The patching logic is too hard to document in a better way...

@rustbot
Copy link
Collaborator

rustbot commented Apr 4, 2024

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-registries Area: registries S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2024
@ehuss
Copy link
Contributor

ehuss commented Apr 4, 2024

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 4, 2024

📌 Commit bbb7520 has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2024
@bors
Copy link
Collaborator

bors commented Apr 4, 2024

⌛ Testing commit bbb7520 with merge 4113935...

@bors
Copy link
Collaborator

bors commented Apr 4, 2024

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 4113935 to master...

@bors bors merged commit 4113935 into rust-lang:master Apr 4, 2024
21 checks passed
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 6, 2024
Update cargo

9 commits in 0637083df5bbdcc951845f0d2eff6999cdb6d30a..28e7b2bc0a812f90126be30f48a00a4ada990eaa
2024-04-02 23:55:05 +0000 to 2024-04-05 19:31:01 +0000
- refactor(toml): Decouple target discovery from Target creation (rust-lang/cargo#13701)
- Don't depend on `?` affecting type inference in weird ways (rust-lang/cargo#13706)
- test(metadata): Show behavior with TOML-specific types (rust-lang/cargo#13703)
- fix: adjust tracing verbosity in list_files_git (rust-lang/cargo#13704)
- doc: comments on `PackageRegistry` (rust-lang/cargo#13698)
- Switch to using gitoxide by default for listing files (rust-lang/cargo#13696)
- Allow precise update to prerelease. (rust-lang/cargo#13626)
- refactor(toml): Split out an explicit step to resolve `Cargo.toml` (rust-lang/cargo#13693)
- chore(deps): update rust crate base64 to 0.22.0 (rust-lang/cargo#13675)

r? ghost
@rustbot rustbot added this to the 1.79.0 milestone Apr 6, 2024
@weihanglo weihanglo deleted the registry-doc branch April 6, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-registries Area: registries S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants