Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(add): Stabilize MSRV-aware version req selection #13608

Merged
merged 2 commits into from
Apr 8, 2024
Merged

feat(add): Stabilize MSRV-aware version req selection #13608

merged 2 commits into from
Apr 8, 2024

Commits on Mar 20, 2024

  1. feat(cli): Add shell completions for 'cargo add -ignore-rust-version'

    @epage
    epage committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    80124ad View commit details
    Browse the repository at this point in the history

  2. feat(add): Stabilize MSRV-aware version req selection 

    This is part of rust-lang#9930 for rust-lang/rfcs#3537

This will make it easier to maintain an MSRV-compliant `Cargo.toml` but
leaves validation up to the user as the resolver will pick newer
versions.
This helps the MSRV-aware workflows enumerated in
rust-lang/rfcs#3537 though it could be confusing to the workflow with an
MSRV-compatible lockfile.
PR rust-lang#13561 at least raises awareness of that discrepancy.

There is an unresolved question on differences in the resolver vs
`cargo add` for dealing with an unset `rust-version`.
However, we are only stabilizing the `cargo add` side which is a very
light two-way door as this is a UX-focused command and not a
programmatic command.

This hasn't gotten much end-user testing but, as its UX focused, that
seems fine.

As such, this seems like it is ready to stabilize.
    @epage
    epage committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    6e4e31b View commit details
    Browse the repository at this point in the history