Skip to content

Basic implementation for cargo install --dry-run #13598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Basic implementation for cargo install --dry-run #13598

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cf2f775
Feat(install/cli): Add new gated --dry-run option
PaulDance Mar 16, 2024
b56d71e
Feat(install): Implement --dry-run
PaulDance Mar 17, 2024
f842f64
Feat(test/compare): Add new status headers to substitute_macros
PaulDance Mar 17, 2024
3b0852d
Test(install): Add tests for --dry-run
PaulDance Mar 17, 2024
419d155
Docs(install): Add --dry-run
PaulDance Mar 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/bin/cargo/commands/install.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,13 @@ pub fn cli() -> Command {
"list",
"List all installed packages and their versions",
))
.arg(
flag(
"dry-run",
"Display what would be installed without actually performing anything (unstable)",
)
.short('n'),
)
Comment on lines +77 to +83
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI

cargo/src/cargo/util/command_prelude.rs

Lines 350 to 352 in 6972630

fn arg_dry_run(self, dry_run: &'static str) -> Self {
self._arg(flag("dry-run", dry_run).short('n'))
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, didn't see that one, thanks!

.arg_ignore_rust_version()
.arg_message_format()
.arg_silent_suggestion()
Expand Down Expand Up @@ -201,6 +208,9 @@ pub fn exec(gctx: &mut GlobalContext, args: &ArgMatches) -> CliResult {
if args.flag("list") {
ops::install_list(root, gctx)?;
} else {
if args.flag("dry-run") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI

cargo/src/cargo/util/command_prelude.rs

Lines 529 to 531 in 6972630

fn dry_run(&self) -> bool {
self.flag("dry-run")
}

gctx.cli_unstable().fail_if_stable_opt("--dry-run", 11123)?;
}
ops::install(
gctx,
root,
Expand Down
78 changes: 41 additions & 37 deletions tests/testsuite/cargo_install/help/stdout.term.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.