Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update msrv #13266

Merged
merged 1 commit into from
Jan 9, 2024
Merged

chore(deps): update msrv #13266

merged 1 commit into from
Jan 9, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 8, 2024

Mend Renovate

This PR contains the following updates:

Package Update Change Pending
MSRV:1 minor 1.73 -> 1.75.0
MSRV:3 minor 1.70.0 -> 1.73 1.75 (+1)

Release Notes

rust-lang/rust (MSRV:1)

v1.75.0

Compare Source

==========================

Language

Compiler

Refer to Rust's [platform support page][platform-support-doc]
for more information on Rust's tiered platform support.

Libraries

Stabilized APIs

These APIs are now stable in const contexts:

Cargo

Rustdoc

Compatibility Notes

Internal Changes

These changes do not affect any public interfaces of Rust, but they represent
significant improvements to the performance or internals of rustc and related
tools.

v1.74.1

Compare Source

===========================

v1.74.0

Compare Source

==========================

Language

Compiler

Libraries

Stabilized APIs

These APIs are now stable in const contexts:

Cargo

Rustdoc

Compatibility Notes

Internal Changes

These changes do not affect any public interfaces of Rust, but they represent
significant improvements to the performance or internals of rustc and related
tools.

None this cycle.


Configuration

📅 Schedule: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@rustbot
Copy link
Collaborator

rustbot commented Jan 8, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 8, 2024
@weihanglo
Copy link
Member

@epage you made it :)

epage added a commit to epage/cargo that referenced this pull request Jan 8, 2024
PR rust-lang#13266 shows that rust-lang#13265 worked, so extending it to also cover
`MSRV:3` updates.

Really, I just forgot...
bors added a commit that referenced this pull request Jan 8, 2024
chore(ci): Fix MSRV:3 updates

PR #13266 shows that #13265 worked, so extending it to also cover `MSRV:3` updates.

Really, I just forgot...
@rustbot rustbot added A-cfg-expr Area: Platform cfg expressions A-credential-provider Area: credential provider for storing and retreiving credentials A-environment-variables Area: environment variables A-home Area: the `home` crate Command-fix labels Jan 8, 2024
@renovate renovate bot changed the title chore(deps): update msrv (1 version) to v1.75.0 chore(deps): update msrv Jan 8, 2024
@epage
Copy link
Contributor

epage commented Jan 9, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 9, 2024

📌 Commit 03beda3 has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2024
@bors
Copy link
Collaborator

bors commented Jan 9, 2024

⌛ Testing commit 03beda3 with merge c0db7f9...

@bors
Copy link
Collaborator

bors commented Jan 9, 2024

☀️ Test successful - checks-actions
Approved by: epage
Pushing c0db7f9 to master...

@bors bors merged commit c0db7f9 into master Jan 9, 2024
42 checks passed
@bors bors deleted the renovate/msrv branch January 9, 2024 02:14
@weihanglo
Copy link
Member

I believe it is definitely not intended, but bump check didn't catch that other public member crates has got an update of their rust-version from workspace inheritance. Personally I like it not bumping, as there is no actual change needed to publish. Just wonder what's our policy in this case?

@epage
Copy link
Contributor

epage commented Jan 9, 2024

I'm fine with that and actually wonder if we should switch the workspace to MSRV:3 so the public crates aren't forced to be released every time.

If we could diff the packages and ignore certain types of changes, that'd be even better :)

@weihanglo
Copy link
Member

wonder if we should switch the workspace to MSRV:3 so the public crates aren't forced to be released every time.

This sounds good and simpler to me 👍🏾

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 10, 2024
Update cargo

14 commits in 2ce45605d9db521b5fd6c1211ce8de6055fdb24e..3e428a38a34e820a461d2cc082e726d3bda71bcb
2024-01-04 18:04:13 +0000 to 2024-01-09 20:46:36 +0000
- refactor: replace `iter_join` with `itertools::join` (rust-lang/cargo#13275)
- docs(unstable): doc comments for items and fields (rust-lang/cargo#13274)
- crates-io: Set `Content-Type: application/json` only for requests with a body payload (rust-lang/cargo#13264)
- fix: only inherit workspace package table if the new package is a member (rust-lang/cargo#13261)
- feat(cli): add colors to `-Zhelp` console output (rust-lang/cargo#13269)
- chore(deps): update msrv (rust-lang/cargo#13266)
- refactor(toml): Make it more obvious to update package-dependent fields (rust-lang/cargo#13267)
- chore(ci): Fix MSRV:3 updates (rust-lang/cargo#13268)
- chore(ci): Shot-in-the-dark fix for MSRV updating (rust-lang/cargo#13265)
- fix: set OUT_DIR for all units with build scripts (rust-lang/cargo#13204)
- fix(manifest): Provide unused key warnings for lints table (rust-lang/cargo#13262)
- test(manifest): Verify we warn on unused workspace.package fields (rust-lang/cargo#13263)
- docs(changelog): Call out cargo-new lockfile change (rust-lang/cargo#13260)
- chore: Add dependency dashboard (rust-lang/cargo#13255)

r? ghost
@rustbot rustbot added this to the 1.77.0 milestone Jan 10, 2024
epage added a commit to epage/cargo that referenced this pull request Jan 18, 2024
We likely don't want to release these packages every 6 months just for
an MSRV bump.
By moving the MSRV out of the package, `cargo bump-check` will ignore
the MSRV bump.

Inspired by rust-lang#13266
epage added a commit to epage/cargo that referenced this pull request Jan 18, 2024
We likely don't want to release these packages every 6 months just for
an MSRV bump.
By moving the MSRV out of the package, `cargo bump-check` will ignore
the MSRV bump.

Inspired by rust-lang#13266
epage added a commit to epage/cargo that referenced this pull request Jan 18, 2024
We likely don't want to release these packages every 6 months just for
an MSRV bump.
By moving the MSRV out of the package, `cargo bump-check` will ignore
the MSRV bump.

Inspired by rust-lang#13266
epage added a commit to epage/cargo that referenced this pull request Jan 18, 2024
We likely don't want to release these packages every 6 months just for
an MSRV bump.
By moving the MSRV out of the package, `cargo bump-check` will ignore
the MSRV bump.

Inspired by rust-lang#13266
bors added a commit that referenced this pull request Jan 19, 2024
chore: Make MSRV=N-2 the workspace default

### What does this PR try to resolve?

Since we update the MSRV every release, `cargo bump-check` forces the changed packages to be released (#13266).
A caveat is that `cargo bump-check` only checks the directory and doesn't do a `.crate` diff, so it misses out of changes to `workspace.package`.
Because of our current workspace default, this means every 6 weeks we ship our user-facing packages but not the internal ones.

This shifts that so we ship our internal packages every 6 weeks and our internal only when changed.

### How should we test and review this PR?

### Additional information

 If `rust-version = "auto"` (rust-lang/rfcs#3537) gets approved, then we will only ship packages that actually change
stupendoussuperpowers pushed a commit to stupendoussuperpowers/cargo that referenced this pull request Feb 28, 2024
PR rust-lang#13266 shows that rust-lang#13265 worked, so extending it to also cover
`MSRV:3` updates.

Really, I just forgot...
stupendoussuperpowers pushed a commit to stupendoussuperpowers/cargo that referenced this pull request Feb 28, 2024
We likely don't want to release these packages every 6 months just for
an MSRV bump.
By moving the MSRV out of the package, `cargo bump-check` will ignore
the MSRV bump.

Inspired by rust-lang#13266
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cfg-expr Area: Platform cfg expressions A-credential-provider Area: credential provider for storing and retreiving credentials A-environment-variables Area: environment variables A-home Area: the `home` crate Command-fix S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants