Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Remove plugin tests #12921

Merged
merged 1 commit into from
Nov 6, 2023
Merged

tests: Remove plugin tests #12921

merged 1 commit into from
Nov 6, 2023

Conversation

epage
Copy link
Contributor

@epage epage commented Nov 6, 2023

Compiler plugins were removed in rust-lang/rust#116412, so we don't need these tests.

As for the plugin field on build-targets, it appears to be stable-but-deprecated, so I left it alone

Compiler plugins were removed in rust-lang/rust#116412, so we don't need
these tests.

As for the `plugin` field on build-targets, it appears to be
[stable-but-deprecated](https://doc.rust-lang.org/cargo/reference/cargo-targets.html#the-plugin-field),
so I left it alone
@rustbot
Copy link
Collaborator

rustbot commented Nov 6, 2023

r? @weihanglo

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 6, 2023
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. Thanks you.

@weihanglo
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 6, 2023

📌 Commit c12c4c3 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2023
@bors
Copy link
Collaborator

bors commented Nov 6, 2023

⌛ Testing commit c12c4c3 with merge c29e9ef...

@bors
Copy link
Collaborator

bors commented Nov 6, 2023

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing c29e9ef to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Nov 6, 2023

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing c29e9ef to master...

@bors bors merged commit c29e9ef into rust-lang:master Nov 6, 2023
20 checks passed
@bors
Copy link
Collaborator

bors commented Nov 6, 2023

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

@epage epage deleted the plugins branch November 6, 2023 21:05
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 8, 2023
Update cargo

7 commits in 65e297d1ec0dee1a74800efe600b8dc163bcf5db..7046d992f9f32ba209a8079f662ebccf9da8de25
2023-11-03 20:56:31 +0000 to 2023-11-08 03:24:57 +0000
- fix: Report more detailed semver errors (rust-lang/cargo#12924)
- Fix some broken links in the man pages (rust-lang/cargo#12929)
- Add better error message when it can not find the search section (rust-lang/cargo#12865)
- Bug 12920 (rust-lang/cargo#12923)
- Update link in environment-variables.md (rust-lang/cargo#12922)
- refactor(toml): Pull out the schema (rust-lang/cargo#12911)
- tests: Remove plugin tests (rust-lang/cargo#12921)

r? ghost
@ehuss ehuss added this to the 1.75.0 milestone Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants