Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for unsupported short config flag #12777

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Add test for unsupported short config flag #12777

merged 2 commits into from
Oct 6, 2023

Conversation

Rustin170506
Copy link
Member

What does this PR try to resolve?

ref #11702

Added unsupported short alias suggestion for --config flag.

How should we test and review this PR?

Check out the unit tests.

Additional information

@rustbot
Copy link
Collaborator

rustbot commented Oct 6, 2023

r? @epage

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-cli Area: Command-line interface, option parsing, etc. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2023
weihanglo
weihanglo approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@weihanglo
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 6, 2023

📌 Commit 2400e42 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2023
@bors
Copy link
Contributor

bors commented Oct 6, 2023

⌛ Testing commit 2400e42 with merge cacebf8...

@weihanglo weihanglo mentioned this pull request Oct 6, 2023
Closed
10 tasks
@bors
Copy link
Contributor

bors commented Oct 6, 2023

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing cacebf8 to master...

@bors bors merged commit cacebf8 into rust-lang:master Oct 6, 2023
19 checks passed
@ehuss ehuss added this to the 1.75.0 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weihanglo weihanglo weihanglo approved these changes

Assignees

@epage epage

Labels
A-cli Area: Command-line interface, option parsing, etc. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.75.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Rustin170506 @rustbot @weihanglo @bors @ehuss @epage