Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test for doctest path problem #8531, and solution #12710

Closed
wants to merge 5 commits into from
Closed

test for doctest path problem #8531, and solution #12710

wants to merge 5 commits into from

Commits on Sep 20, 2023

  1. Properly set dylib search path for doctests

    Fixes #8531.
    
    This issue was introduced by 3fd2814.
    Prior to that commit, the `rustdoc_process` function took other branch
    of the if statement being modified by this commit. The flag was
    previously called `is_host`, and `rustdoc` was run reporting `false`. In
    that commit, the flag was changed to `is_rustc_tool`, and rustdoc began
    reporting `true`, which resulted in the native directories added by
    build scripts no longer being appended to LD_LIBRARY_PATH when running
    doctests.
    
    This commit changes the behavior so that we are always appending the
    same set of paths, and the only variance is if we are cross compiling or
    not. An alternative would be to change rustdoc to always pass
    `kind: CompileKind::Host, is_rustc_tool: false`, but as rustdoc is in
    fact a rustc tool, that feels wrong. The commit which introduced the bug
    did not include context on why the flag was changed to `is_rustc_tool`,
    so I don't have a sense for if we should just change that flag to mean
    something else.
    
    While the test suite previously had an explicit test for the
    library path behavior of `cargo run`, it did not test this for various
    test forms. This commit modifies the test to ensure the behavior is
    consistent across `run`, normal tests, and doctests.
    sgrif authored and tompscanlan committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    b93c19e View commit details
    Browse the repository at this point in the history
  2. test for doctest path problem #8531, and solution

    * add test reproducing #8531
    * re-use solution from #10469
    * solution fixes test
    tompscanlan committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    e7f7058 View commit details
    Browse the repository at this point in the history
  3. fmt

    tompscanlan committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    7f4704d View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2023

  1. Configuration menu
    Copy the full SHA
    3c2557e View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. update comment with input

    Tom Scanlan committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    394aa9d View commit details
    Browse the repository at this point in the history