Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 0.75.0; update changelog #12539

Merged
merged 5 commits into from
Aug 22, 2023
Merged

Conversation

weihanglo
Copy link
Member

@rustbot
Copy link
Collaborator

rustbot commented Aug 22, 2023

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 22, 2023
@weihanglo
Copy link
Member Author

Can't reproduce the resolver test failure. Could be a flaky test?

@bors try

@bors
Copy link
Contributor

bors commented Aug 22, 2023

⌛ Trying commit ac86772 with merge 01d7583...

@ehuss
Copy link
Contributor

ehuss commented Aug 22, 2023

The resolver issue is #6258. I'm not sure what exactly is going on with that particular test. Maybe it needs more ticks to finish? Unfortunately due to its nature, there are pathological cases that can take an indefinite amount of time to finish, and proptesting can randomly hit those situations.

@ehuss
Copy link
Contributor

ehuss commented Aug 22, 2023

It also looks like your try build hit another error:

---- registry_auth::token_not_logged stdout ----
req: Request {
    url: Url {
        scheme: "http",
        cannot_be_a_base: false,
        username: "",
        password: None,
        host: Some(
            Ipv4(
                127.0.0.1,
            ),
        ),
        port: Some(
            39167,
        ),
        path: "/index/config.json",
        query: None,
        fragment: None,
    },
    method: "get",
    authorization: None,
    if_modified_since: None,
    if_none_match: None,
}
req: Request {
    url: Url {
        scheme: "http",
        cannot_be_a_base: false,
        username: "",
        password: None,
        host: Some(
            Ipv4(
                127.0.0.1,
            ),
        ),
        port: Some(
            39167,
        ),
        path: "/index/config.json",
        query: None,
        fragment: None,
    },
    method: "get",
    authorization: Some(
        "a-unique_token",
    ),
    if_modified_since: None,
    if_none_match: None,
}
req: Request {
    url: Url {
        scheme: "http",
        cannot_be_a_base: false,
        username: "",
        password: None,
        host: Some(
            Ipv4(
                127.0.0.1,
            ),
        ),
        port: Some(
            39167,
        ),
        path: "/index/config.json",
        path: "/index/config.json",
        query: None,
        fragment: None,
    },
    method: "get",
    authorization: Some(
        "a-unique_token",
    ),
    if_modified_since: None,
    if_none_match: None,
}
req: Request {
    url: Url {
        scheme: "http",
        cannot_be_a_base: false,
        username: "",
        password: None,
        host: Some(
            Ipv4(
                127.0.0.1,
            ),
        ),
        port: Some(
            39167,
        ),
        path: "/index/3/f/foo",
        query: None,
        fragment: None,
    },
    method: "get",
    authorization: Some(
        "a-unique_token",
    ),
    if_modified_since: None,
    if_none_match: None,
}
thread 'registry_auth::token_not_logged' panicked at 'assertion failed: `(left == right)`
  left: `8`,
 right: `7`', tests/testsuite/registry_auth.rs:498:5

I don't think I have seen that before. I'm not really sure what might have caused that. We should consider adding some more debug information to that test.

@ehuss
Copy link
Contributor

ehuss commented Aug 22, 2023

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Aug 22, 2023

📌 Commit ac86772 has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2023
@bors
Copy link
Contributor

bors commented Aug 22, 2023

⌛ Testing commit ac86772 with merge 3e84456...

@bors
Copy link
Contributor

bors commented Aug 22, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 22, 2023
@ehuss
Copy link
Contributor

ehuss commented Aug 22, 2023

Proptest error # #6258 again 😦 .

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2023
@bors
Copy link
Contributor

bors commented Aug 22, 2023

⌛ Testing commit ac86772 with merge 5155d3f...

@bors
Copy link
Contributor

bors commented Aug 22, 2023

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 5155d3f to master...

@bors bors merged commit 5155d3f into rust-lang:master Aug 22, 2023
13 of 20 checks passed
@weihanglo weihanglo deleted the version-bump branch August 22, 2023 16:24
@ehuss ehuss added this to the 1.74.0 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants