Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta 1.69] Backport #11936 - Don't query permutations of the path prefix #11940

Closed
wants to merge 2 commits into from

Conversation

arlosi
Copy link
Contributor

@arlosi arlosi commented Apr 6, 2023

Backport of #11936 to beta to reduce the number of 404 requests hitting index.crates.io before sparse default hits stable.

@rustbot
Copy link
Collaborator

rustbot commented Apr 6, 2023

r? @weihanglo

(rustbot has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Apr 6, 2023

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.69.0. Please double check that you specified the right target!

@rustbot rustbot added A-registries Area: registries A-testing-cargo-itself Area: cargo's tests S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 6, 2023
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense backporting this.

@ehuss
Copy link
Contributor

ehuss commented Apr 8, 2023

The sparse default is in 1.70, so backporting to 1.69 would only affect people who have opted-in.

I'm not against backporting this, it seems fine. But I would also say that the small amount of extra 404 traffic probably isn't very significant.

@arlosi
Copy link
Contributor Author

arlosi commented Apr 11, 2023

Closing since the impact is likely to be low, given that it's not yet default.

@arlosi arlosi closed this Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-registries Area: registries A-testing-cargo-itself Area: cargo's tests S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants