Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/doc/src/reference/build-scripts.md: a{n =>} benchmark target #11908

Merged
merged 1 commit into from
Mar 29, 2023
Merged

src/doc/src/reference/build-scripts.md: a{n =>} benchmark target #11908

merged 1 commit into from
Mar 29, 2023

Conversation

nabijaczleweli
Copy link
Contributor

What does this PR try to resolve?

"an benchmark target"

How should we test and review this PR?

idk, reading it is a good start, maybe compare to the original. it may help to vocalise out loud that b is not a vowel, too

@rustbot
Copy link
Collaborator

rustbot commented Mar 29, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 29, 2023
@ehuss
Copy link
Contributor

ehuss commented Mar 29, 2023

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 29, 2023

📌 Commit 3c7578f has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 29, 2023
@bors
Copy link
Collaborator

bors commented Mar 29, 2023

⌛ Testing commit 3c7578f with merge 1f63f1d...

@bors
Copy link
Collaborator

bors commented Mar 29, 2023

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 1f63f1d to master...

@bors bors merged commit 1f63f1d into rust-lang:master Mar 29, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 1, 2023
Update cargo

9 commits in 145219a9f089f8b57c09f40525374fbade1e34ae..0e474cfd7b16b018cf46e95da3f6a5b2f1f6a9e7
2023-03-27 01:56:36 +0000 to 2023-03-31 23:15:58 +0000
- Add delays to network retries. (rust-lang/cargo#11881)
- Add a note to `cargo logout` that it does not revoke the token. (rust-lang/cargo#11919)
- Sync external-tools JSON docs. (rust-lang/cargo#11918)
- Drop derive feature from serde in cargo-platform (rust-lang/cargo#11915)
- Disable test_profile test on windows-gnu (rust-lang/cargo#11916)
- src/doc/src/reference/build-scripts.md: a{n =>} benchmark target (rust-lang/cargo#11908)
- Documented working directory behaviour for `cargo test`, `cargo bench` and `cargo run` (rust-lang/cargo#11901)
- docs(contrib): Link to office hours doc (rust-lang/cargo#11903)
- chore: Upgrade to clap v4.2 (rust-lang/cargo#11904)
@ehuss ehuss added this to the 1.70.0 milestone Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants