Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semver checks for 1.68 #11627

Closed
wants to merge 1 commit into from
Closed

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Jan 25, 2023

The diagnostic message for one of the SemVer checks needs to be updated for 1.67.

@rustbot
Copy link
Collaborator

rustbot commented Jan 25, 2023

r? @epage

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 25, 2023
@ehuss
Copy link
Contributor Author

ehuss commented Jan 25, 2023

CAUTION ⚠ This should not be merged until after the 1.68 stable release on 2023-03-09.

@ehuss ehuss changed the title Update semver checks for 1.67 Update semver checks for 1.68 Jan 26, 2023
@ehuss ehuss marked this pull request as draft January 26, 2023 15:22
@ehuss
Copy link
Contributor Author

ehuss commented Jan 26, 2023

Oops, I think I got confused. This isn't needed until 6 weeks from now. I suppose I'll leave it here until then.

@weihanglo weihanglo added S-blocked S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-blocked labels Jan 26, 2023
@epage epage added S-blocked and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2023
@weihanglo
Copy link
Member

Close in favor of #11817.

@weihanglo weihanglo closed this Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants