-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add semver rule for lints #11596
Add semver rule for lints #11596
Conversation
r? @epage (rustbot has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just want to check if there is any previous discussion from other Rust teams, specifically clippy team.
Since it is not possible to have "private" features, it can be an issue if users enable it without understanding what it is for.
@bors r+ |
☀️ Test successful - checks-actions |
3 commits in 50eb688c2bbea5de5a2e8496230a7428798089d1..985d561f0bb9b76ec043a2b12511790ec7a2b954 2023-01-19 10:09:05 +0000 to 2023-01-20 14:39:28 +0000 - Stabilize sparse-registry (rust-lang/cargo#11224) - Wrapper type for data that should never be logged (rust-lang/cargo#11545) - Add semver rule for lints (rust-lang/cargo#11596)
Update cargo 3 commits in 50eb688c2bbea5de5a2e8496230a7428798089d1..985d561f0bb9b76ec043a2b12511790ec7a2b954 2023-01-19 10:09:05 +0000 to 2023-01-20 14:39:28 +0000 - Stabilize sparse-registry (rust-lang/cargo#11224) - Wrapper type for data that should never be logged (rust-lang/cargo#11545) - Add semver rule for lints (rust-lang/cargo#11596) r? `@ghost`
This adds a new rule to the semver compatibility list explaining the expectations around diagnostic lints.
cc #8736