Improve startup time of bash completion. #10365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cargo list` takes about .15 seconds on my computer which is substantial enough to be the slowest command run when my shell starts according to sstephenson's bashprof. This commit defers running `cargo list` until we need it for the first time.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
@bors: r+ Thanks! |
|
📌 Commit 7f3f9ed has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 9, 2022
Update cargo 5 commits in 25fcb135d02ea897ce894b67ae021f48107d522b..c082648646cbb2be266df9ecbcdc253058158d68 2022-02-01 01:32:48 +0000 to 2022-02-08 14:55:05 +0000 - Add rustup link (rust-lang/cargo#10371) - Improve startup time of bash completion. (rust-lang/cargo#10365) - Stabilize `-Ztimings` as `--timings` (rust-lang/cargo#10245) - Remove needless borrow (rust-lang/cargo#10360) - Compute non custom build and non transitive deps for doc (rust-lang/cargo#10341)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo listtakes about .15 seconds on my computer which issubstantial enough to be the slowest command run when my shell starts
according to sstephenson's bashprof.
This commit defers running
cargo listuntil we need it for the firsttime.
Testing
After starting a new shell (which has loaded cargo's bash completion)
type
cargo <TAB><TAB>and see the output matches the output prior tothis change (ie: the commands given by
cargo list). You shouldobserve a small delay. You should observe no such delay on subsequent
attempts within the same session.