Use 1.51.0 in old cargos test

[Rustin170506]

Remove TODO.
If the default toolchain is the same as "stable", just skip the avoids_split_debuginfo_collision test.

[rust-highfive]

r? @alexcrichton

(rust-highfive has picked a reviewer for you, use r? to override)

[ehuss]

Thanks! Unfortunately it looks like these tests have atrophied over time. Would you be willing to try to get them back into running shape? If not, that's ok, I can probably get them working again. It might be somewhat involved to make the output conditional based on the version.

It looks like all versions from 1.51 onwards aren't working due to some output changes (and there have been various output changes over time).

I'm also wondering if it might be feasible to remove the #[ignore] lines to prevent that. I can't remember if there was a really good reason for that.

[Rustin170506]

Would you be willing to try to get them back into running shape?

I will try to fix it in the next week.

[Rustin170506]

@ehuss It's already working correctly locally.
I think the reason it was originally ignored was probably because it relied on a couple of specific versions of toolchain.
Do you think we need to run a separate GitHub actions job for it?

[Rustin170506]

I think the reason it was originally ignored was probably because it relied on a couple of specific versions of toolchain.
Do you think we need to run a separate GitHub actions job for it?

@ehuss Happy New Year! Could you please take a look?

[ehuss]

I'd prefer not to change CI to accommodate these tests for now. It looks like index_cache_rebuild fundamentally needs 1.48 installed, so I would leave that with #[ignore] for now.

As for avoids_split_debuginfo_collision, that test needs two different toolchains. If the default toolchain is stable, then it won't work. I probably never tested that scenario. Also, I think maybe the test needs to be updated due to changes in #9653. I think one way to fix it is to check if the default toolchain is the same as "stable", just skip the test.

[Rustin170506]

@ehuss
Could you please take a look? Thanks! 💚 💙 💜 💛 ❤️

[Rustin170506]

nightly also work!

[Rustin170506]

@rustbot ready

[rustbot]

Error: The feature shortcut is not enabled in this repository.
To enable it add its section in the triagebot.toml in the root of the repository.

Please let @rust-lang/release know if you're having trouble with this bot.

[Rustin170506]

@rustbot ready

[Rustin170506]

Friendly ping~ @ehuss

Could you please take a look? Thanks! 💚 💙 💜 💛 ❤️

[ehuss]

Sorry about the delay.

It looks like new_features has fallen behind again. Starting with 1.60, namespaced-features has been stabilized. That means the validity checks will need to have three different checks:

• < 1.51
• >= 1.51 && < 1.60
• >= 1.60

Can you add the new 1.60 behavior?

[Rustin170506]

I have tested on these tool chains:

➜  cargo git:(rustin-patch-test) rustup toolchain list          
stable-x86_64-apple-darwin
beta-x86_64-apple-darwin (default)
nightly-x86_64-apple-darwin
1.11.0-x86_64-apple-darwin
1.12.0-x86_64-apple-darwin
1.48.0-x86_64-apple-darwin
1.50.0-x86_64-apple-darwin
1.51.0-x86_64-apple-darwin
1.52.0-x86_64-apple-darwin
1.53.0-x86_64-apple-darwin
1.59.0-x86_64-apple-darwin

[ehuss]

Thanks!

@bors r+

[bors]

📌 Commit 9d93415 has been approved by ehuss

[bors]

⌛ Testing commit 9d93415 with merge 188298f...

[bors]

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 188298f to master...