Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress Bar doesn't update new lines when width is under 120 char #6223

Closed
khionu opened this issue Oct 26, 2018 · 3 comments
Closed

Progress Bar doesn't update new lines when width is under 120 char #6223

khionu opened this issue Oct 26, 2018 · 3 comments

Comments

@khionu
Copy link
Member

khionu commented Oct 26, 2018

Steps to reproduce

  1. Open Git Bash on Windows in crate directory
  2. Do not adjust the window
  3. Run cargo build

Result

https://files.khionu.net/ss/2018-10-26_19-11-11.gif

Note, this does not occur after making the window larger

@ehuss
Copy link
Contributor

ehuss commented Oct 26, 2018

This should be fixed in 1.31 (sorta, it's locked at 60 columns). If you make your terminal over 120 characters wide, it should work. Another option is to set TERM=dumb environment variable, although that will also disable color. Apologies, I hadn't considered backporting this into 1.30.

@khionu
Copy link
Member Author

khionu commented Oct 26, 2018

I've confirmed that this is fixed on nightly. Could this be backported as a patchfix?

@alexcrichton
Copy link
Member

Thanks for the confirmation! This'll be in 1.31 and if a 1.30.1 release happens we can consider putting this in there too.

@khionu khionu changed the title Progress Bar doesn't update new lines with Git Bash (MINGW64?) Progress Bar doesn't update new lines when width is under 120 char Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants