Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that you shouldn't explicitly set --target to the default #3817

Closed
lilith opened this issue Mar 11, 2017 · 5 comments · Fixed by #7733
Closed

Document that you shouldn't explicitly set --target to the default #3817

lilith opened this issue Mar 11, 2017 · 5 comments · Fixed by #7733
Labels
A-documenting-cargo-itself Area: Cargo's documentation C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`

Comments

@lilith
Copy link
Contributor

lilith commented Mar 11, 2017

Using a --target value that matches rustup show causes a range of bugs.

  1. Two different crates with name 'X' error only when using --target=  #3665
  2. MSVC: Spurious PDB error on the bots rust#33145 (comment)
cargo 0.18.0-nightly (5db6d64 2017-03-03)
rustc 1.17.0-nightly (b1e31766d 2017-03-03)

Both target/$PROFILE/ and target/$TARGET/$PROFILE folders are populated with binaries, nearly all of which are duplicates.

Issues seem to be more common in projects with a sufficiently large dependency graph. And when compiling for windows targets.
@alexcrichton
Copy link
Member

I... is there a bug here? Sorry I'm not really following what would be necessary to close this issue...

@lilith
Copy link
Contributor Author

lilith commented Mar 12, 2017

There's a theme; it's possible the two bugs have a shared root cause. Ideas as to where to look would be helpful.

I would also suggest warning users away from --target=[default] in the meantime.

@alexcrichton
Copy link
Member

Ah ok, would you be ok if I closed this issue in favor of those two then? This issue may not itself facilitate the fix much and we can otherwise continue discussion of the various bugs in those respective places.

@lilith
Copy link
Contributor Author

lilith commented Mar 14, 2017

I would suggest documentation that using --target with the default target is not tested/supported yet.

@carols10cents carols10cents changed the title Explicitly setting --target to the default causes widespread failures Document that you shouldn't explicitly set --target to the default Oct 2, 2017
@carols10cents carols10cents added A-documenting-cargo-itself Area: Cargo's documentation C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` labels Oct 2, 2017
@dwijnand
Copy link
Member

Is that still worth documenting, (almost) 2 years in?

ehuss added a commit to ehuss/cargo that referenced this issue Dec 21, 2019
@ehuss
Try to be clearer about how --target is different.
47a46ae 
Closes rust-lang#3817
@ehuss ehuss mentioned this issue Dec 21, 2019
Merged
bors added a commit that referenced this issue Dec 22, 2019
@bors
Auto merge of #7733 - ehuss:doc-updates, r=Eh2406
741f0e5 
Various doc updates

This is a collection of documentation updates that have been in my todo list for a while. Each change is in a separate commit.

The "features" chapter will probably get significant changes in the future, as it is pretty bare right now. Similarly the "workspace" chapter could probably use more examples.

Closes #3062
Closes #3817
Closes #3971
Closes #4212
Closes #4438
Closes #4756
Closes #5822
Closes #6913
Closes #7055
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-documenting-cargo-itself Area: Cargo's documentation C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Various doc updates ehuss/cargo
4 participants
@alexcrichton @lilith @carols10cents @dwijnand