-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider renaming [gc]
config table.
#14292
Comments
Maybe some sub-table like [cache.global]
auto-clean-frequency = "1 day" And someday later we got #5931 and #13061, we can expand to fine-grained control when needed. [cache.global]
# The default for all cache. Overwritable.
[cache.index]
# for registry index cache
[cache.source]
# git or registry source
[cache.shared-artifacts]
# per-user cache
[cache.local-artifacts]
# workspace-local target dirs |
I was talking with someone about logging ( I could see our options being
I don't want to block work on this on future possibilities but wanted to add to the conversation "there might be resources to reclaim besides caches". Do we want to limit |
I just wanted to add that I read that there was a proposal to "stabilize a minimal amount of garbage collection" and my heart sank. I said aloud "and this is the end of Rust". I forced myself to read further and realized that this is about file cleanup. Please reconsider using the phrase "garbage collection" as this strongly conflicts (on a verbiage-level) with one of the best features of the language. |
I'll repost what I said in #14287, so people don't have to go searching for it:
|
I don't feel strongly one way or the other. But I will say that as a user I wouldn't expect any aspect of log handling to be configured under the same namespace as the handling of artifacts that are actually functionally important to building. That doesn't mean it couldn't make sense, maybe? But it would at least be very unexpected to me. They feel like totally separate concerns. |
In #14287 (comment), it was suggested to have a different name for the
[gc]
table. The intent is to make it something clearer to the user.My intent is to have the
frequency
option affect all cache cleaning. That is, I think there should be one option for configuring the "once per day" cleaning of caches. I would be concerned that trying to define properties for various different kinds of caches could add complexity. To that end, I might suggest something like:I don't have a particular opinion about the other config options, since I don't know what those will ultimately look like (tracked in #13061). In the meantime, I would toss them in some sub-table until a more permanent solution is picked. Perhaps something like
cache.global-clean
or something like that.Feel free to suggest other ideas, preferably with your reasons for what you suggest.
The text was updated successfully, but these errors were encountered: