-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize cargo logout
#11910
Comments
@rfcbot fcp merge |
Team member @ehuss has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
Is there any mention when running the command that the token is not revoked and that you may want to visit the website to revoke it too? |
🔔 This is now entering its final comment period, as per the review above. 🔔 |
Seems reasonable. Posted #11919 with that suggestion. |
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. This will be merged soon. |
This is a proposal to stabilize the
cargo logout
command.This command is a fairly straightforward companion to
cargo login
. It will remove the token for a registry from~/.cargo/credentials.toml
, or from a credential store with-Zcredential-process
. This was added as part of-Zcredential-process
because otherwise it would be quite awkward to try to remove a credential. However, it also has utility for the traditionalcredentials.toml
file in the same way thatcargo login
is helpful. A user can manually edit the file in both cases, but providing a CLI command should be more convenient.Other tools have similar functionality:
npm logout
gem signout
yarn logout
dart pub token remove
docker logout
aws logout
gh auth logout
(and probably many others)
I do not know of any concerns about the design or implementation of the command. Since I doubt we will discover anything new by keeping it unstable, I'd like to propose to stabilize it.
The text was updated successfully, but these errors were encountered: