Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize cargo logout #11910

Closed
ehuss opened this issue Mar 29, 2023 · 6 comments · Fixed by #11950
Closed

Stabilize cargo logout #11910

ehuss opened this issue Mar 29, 2023 · 6 comments · Fixed by #11950

Comments

@ehuss
Copy link
Contributor

ehuss commented Mar 29, 2023

This is a proposal to stabilize the cargo logout command.

This command is a fairly straightforward companion to cargo login. It will remove the token for a registry from ~/.cargo/credentials.toml, or from a credential store with -Zcredential-process. This was added as part of -Zcredential-process because otherwise it would be quite awkward to try to remove a credential. However, it also has utility for the traditional credentials.toml file in the same way that cargo login is helpful. A user can manually edit the file in both cases, but providing a CLI command should be more convenient.

Other tools have similar functionality:

(and probably many others)

I do not know of any concerns about the design or implementation of the command. Since I doubt we will discover anything new by keeping it unstable, I'd like to propose to stabilize it.

@ehuss
Copy link
Contributor Author

ehuss commented Mar 29, 2023

@rfcbot fcp merge

@rfcbot
Copy link
Collaborator

rfcbot commented Mar 29, 2023

Team member @ehuss has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period An FCP proposal has started, but not yet signed off. disposition-merge FCP with intent to merge labels Mar 29, 2023
@Nemo157
Copy link
Member

Nemo157 commented Mar 29, 2023

Is there any mention when running the command that the token is not revoked and that you may want to visit the website to revoke it too?

@rfcbot rfcbot added final-comment-period FCP — a period for last comments before action is taken and removed proposed-final-comment-period An FCP proposal has started, but not yet signed off. labels Mar 30, 2023
@rfcbot
Copy link
Collaborator

rfcbot commented Mar 30, 2023

🔔 This is now entering its final comment period, as per the review above. 🔔

@ehuss
Copy link
Contributor Author

ehuss commented Mar 31, 2023

Is there any mention when running the command that the token is not revoked and that you may want to visit the website to revoke it too?

Seems reasonable. Posted #11919 with that suggestion.

@rfcbot rfcbot added finished-final-comment-period FCP complete and removed final-comment-period FCP — a period for last comments before action is taken labels Apr 9, 2023
@rfcbot
Copy link
Collaborator

rfcbot commented Apr 9, 2023

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants