-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate cargo future incompatibilities reports #11594
Comments
Can you say more about what this issue is about? What kind of concerns do you have? It is normal for cargo to increment the |
Thank you for your response. The issue here is the increment in |
Yea, if the report is identical to an existing one on-disk, it sounds reasonable to reuse an existing ID and avoid writing to the file. I think the code for that would likely go around here. |
Avoid saving the same future_incompat warning multiple times ### What does this PR try to resolve? Each time a build, that causes future_incompat warnings, is run, a report about each warning is created and saved to disk with a new id quicky filling up the JSON file. This PR adds a check if the report is already on disk and avoids saving a new instance of it. Fixes #11594. ### How should we test and review this PR? Perform a build that gives one or more future_incompat warnings, and see that they are added to the JSON file only once when the build is repeated.
Problem
I have been getting warnings for the traitobject v0.1.0 crate and the number of future incompatibility reports has reached to 950, with the size of the .future-incompat-report.json file at 38kB.
Steps
No response
Possible Solution(s)
Check and return an id if it already exists.
Notes
No response
Version
The text was updated successfully, but these errors were encountered: