Skip to content

Commit

Permalink
chore(ci): Don't check cargo against beta channel
Browse files Browse the repository at this point in the history
We already only partially check it and it has been a source of false
positives.

While there is trust in the job, contributors and maintainers go into
the job assuming there is a problem and it takes time to break that
assumption.

If we lose trust in the job, we then won't trust it when it fails for
other reasons.

This also increases the risk of us not seeing other problems
`bump-checks` is meant to find if the steps in the job get re-arranged
to make this one of the early ones.
  • Loading branch information
epage committed Apr 29, 2024
1 parent b74573b commit 705c4f1
Showing 1 changed file with 13 additions and 4 deletions.
17 changes: 13 additions & 4 deletions crates/xtask-bump-check/src/xtask.rs
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,19 @@ fn bump_check(args: &clap::ArgMatches, gctx: &cargo::util::GlobalContext) -> Car
let changed_members = changed(&ws, &repo, &base_commit, &head_commit)?;
let status = |msg: &str| gctx.shell().status(STATUS, msg);

// Don't check against beta and stable branches,
// as the publish of these crates are not tied with Rust release process.
// See `TO_PUBLISH` in publish.py.
let crates_not_check_against_channels = ["home"];
let crates_not_check_against_channels = [
// High false positive rate between beta branch and requisite version bump soon after
//
// Low risk because we always bump the "major" version after beta branch; we are
// only losing out on checks for patch releases.
//
// Note: this is already skipped in `changed`
"cargo",
// Don't check against beta and stable branches,
// as the publish of these crates are not tied with Rust release process.
// See `TO_PUBLISH` in publish.py.
"home",
];

status(&format!("base commit `{}`", base_commit.id()))?;
status(&format!("head commit `{}`", head_commit.id()))?;
Expand Down

0 comments on commit 705c4f1

Please sign in to comment.