feat: make refresh more robust #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #66
By comparing the set of repositories before reloading and the set of repositories got from reloading, I could infer which repository was reloaded, which was not and which was recently added.
I tried to add tests to verify this behavior but was limited by our current tests infra. It was hard to load more than one repo during reloading due to the way we are mocking the
RepositoryLoader.The refresh process of each repository (config refreshing, etc...) is already granular, and each refresh task run concurrently with the other using
tokio::join!. Therefore, no further action is needed in this regard.