Skip to content

Conversation

@chriskrycho
Copy link
Contributor

@chriskrycho chriskrycho commented Dec 2, 2024

No more need to manually wrap lines? SOUNDS GREAT.

This PR:

  • Introduces the configuration.
  • Applies to it all the files in the repo we want to add it to.
  • Adds a .git-blame-ignore-revs file to make it so git blame will skip the formatting commit on GitHub (you may want to wire this up locally!).

Future PRs will likely configure a GitHub Action to automatically run dprint fmt after commit, inspired by how the DefinitelyTyped project does it, and may apply this same change to the nostarch output (though likely as part of the nostarch script).

Fixes #3922

This appears to still work with pulldown-cmark, but not necessarily in
all renderers, and (more to the point at present) is not compatible with
dprint, which does not like the line wrapping that way!
No more need to manually wrap lines? GREAT.
@chriskrycho chriskrycho marked this pull request as ready for review December 3, 2024 14:58
@chriskrycho chriskrycho merged commit d83137d into main Dec 3, 2024
6 checks passed
@chriskrycho chriskrycho deleted the dprint branch December 3, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

infra: auto-format changes with dprint?

2 participants