Add HTML-based redirects for previous chapter numbering #4061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike the redirects we have in place for the previous editions, this simply performs an in-place redirect, using the built-in mechanism for this in mdbook. As an alternative, we could hand-craft HTML pages to do what the redirect pages for the first and second edition do: present a page and let the user click through proactively.
|
@carols10cents I am going ahead merging this as is so that whenever a roll-up happens upstream, all existing links will at least be correctly redirected. However, I am happy to revisit and do the manual work of hand-authored HTML pages with redirect info people can click through if that’s preferable here for whatever reason! |
14 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike the redirects we have in place for the previous editions, this simply performs an in-place redirect, using the built-in mechanism for this in mdbook. As an alternative, we could hand-craft HTML pages to do what the redirect pages for the first and second edition do: present a page and let the user click through proactively. What we cannot do, unfortunately, is have those pages present without showing up in the sidebar nav (see rust-lang/mdBook#702 and rust-lang/mdBook#830), which we distinctly do not want.