Skip to content

Introduce handling for accessible/semantic note rendering in HTML #3907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Apr 30, 2024
Merged

Introduce handling for accessible/semantic note rendering in HTML #3907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
da52d2a
Implement functionality for actual rewrite
chriskrycho Apr 25, 2024
d098a33
Integrate `rewrite` into an mdBook preprocessor
chriskrycho Apr 25, 2024
077b0c9
Rename to `mdbook-simple-note`. No need to be so verbose!
chriskrycho Apr 26, 2024
563d52b
Add support for headings.
chriskrycho Apr 26, 2024
301c704
Rename to `mdbook-trpl-note`. This is *very* specific.
chriskrycho Apr 26, 2024
5f19f77
Invert the order of the pattern match for readability.
chriskrycho Apr 26, 2024
804a6ad
Do *not* remove the leading “Note: ” from notes.
chriskrycho Apr 26, 2024
215420a
Rename header tests for clarity (prep for adding more tests!).
chriskrycho Apr 26, 2024
8c899a3
Correctly handle adjacent quotes and notes.
chriskrycho Apr 26, 2024
2eabe4e
Remove `aria-label` from `<section>`s.
chriskrycho Apr 26, 2024
3032068
Prepare to merge into TRPL repo
chriskrycho Apr 26, 2024
f48b281
Convert to a workspace
chriskrycho Apr 29, 2024
da9e96e
Modernize tools package contents
chriskrycho Apr 29, 2024
456a8dc
Merge `mdbook-trpl-note` into the repository
chriskrycho Apr 29, 2024
33fb62e
Make mdbook a workspace root dependency
chriskrycho Apr 29, 2024
da7a20f
Emit semantic HTML instead of blockquotes for notes
chriskrycho Apr 25, 2024
593ec2a
Do not apply semantic note handling to nostarch
chriskrycho Apr 29, 2024
427f7d3
Update CI config for workspace and mdbook-trpl-note
chriskrycho Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ jobs:
mkdir bin
curl -sSL https://github.com/rust-lang/mdBook/releases/download/v0.4.21/mdbook-v0.4.21-x86_64-unknown-linux-gnu.tar.gz | tar -xz --directory=bin
echo "$(pwd)/bin" >> ${GITHUB_PATH}
- name: Install mdbook-trpl-note
run: cargo install --path packages/mdbook-trpl-note
- name: Install aspell
run: sudo apt-get install aspell
- name: Install shellcheck
Expand Down
Loading