Fix tests on nightly. #1958
Closed
Fix tests on nightly. #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehuss
force-pushed
the
cfg-test-no-compile
branch
from
bdebea5 to
598e154
Compare
|
Looks good to me! @carols10cents any opinions? |
|
So the first one isn't supposed to compile, so ignoring it is correct. The second one can compile with some added hidden code, so that's how I'd like to fix that one. I've pushed a fix to master 29fe982 and I'm closing this. |
|
Thanks @carols10cents ❤️ . I was reluctant to copy everything. It would be nice if it was easier to reuse other code blocks. I have updated rust-lang/rust#60791 with the changes, hopefully it can get merged before monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since rust-lang/rust#59940, test blocks are now included. These code blocks are incomplete, and now cause test failures.