Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ch07 - remove note regarding use and relative path #1820

Merged
merged 1 commit into from
Sep 15, 2019
Merged

ch07 - remove note regarding use and relative path #1820

merged 1 commit into from
Sep 15, 2019

Conversation

BooleanCat
Copy link

I was working through the rust book and saw that chapter 7-2 talked about quirk of use super when bringing items into scope with use from a relative path. I wanted to see the error message generated when I deliberately omit self and it succeeded!

Sure enough it looks like 1.32 added this feature to rust.

@carols10cents
Copy link
Member

Thanks! This will fix #1807. However, for the moment, we've frozen the book content at 1.31 -- we'll merge this when we move the book content to the next Rust version.

@carols10cents carols10cents added the blocked Blocked on a change we need to make in this repo label Feb 17, 2019
@carols10cents
Copy link
Member

Note to self: this text is now in src/ch07-04-bringing-paths-into-scope-with-the-use-keyword.md and this change needs to be made there instead. @BooleanCat if you'd like to update this PR, that'd be great, otherwise I'll take care of it when we decide to change the version the book uses!

@BooleanCat
Copy link
Author

@carols10cents I've moved the change over to the new file :)

@carols10cents carols10cents added this to the ch7 milestone Apr 12, 2019
@BooleanCat
Copy link
Author

Resolved a merge conflict

@steveklabnik
Copy link
Member

We're past 1.31 now; let's merge! Thanks so much @BooleanCat

@steveklabnik steveklabnik merged commit 2de564b into rust-lang:master Sep 15, 2019
tmandry added a commit to tmandry/rust that referenced this pull request Sep 18, 2019
Update books

## book

24 commits in 7ddc46460f09a5cd9bd2a620565bdc20b3315ea9..871416b85c1a73717d65d6f4a9ea29e5aef3db0e
2019-06-27 09:50:36 -0400 to 2019-09-16 09:46:20 -0400
- Ch16-2 add missing Ferris (rust-lang/book#2033)
- Update version mentioned on the front page
- Update error messages (rust-lang/book#1737)
- Update version of Rust used to 1.37
- Replace Cargo docs link with a more specific link (rust-lang/book#2066)
- Added missing await reserved keyword (rust-lang/book#2064)
- add does_not_compile for a snippet (rust-lang/book#2056)
- Added second missing dyn (rust-lang/book#2046)
- Removed unnecessary & in function call (rust-lang/book#2038)
- Printing non-Display structs is a *compile* error (rust-lang/book#2031)
- Update Readme mdBook version to match linked file (rust-lang/book#2012)
- Update loose mdbook version reference (rust-lang/book#2003)
- Added a bullet point to have list of things unsafe allows for match u… (rust-lang/book#1993)
- Rewrote a confusing sentence (rust-lang/book#1986)
- Replace deprecated `...` range syntax with `..=` (rust-lang/book#1977)
- correct wording for integration test doc (rust-lang/book#1971)
- Mark the dangle function as does_not_compile (rust-lang/book#1965)
- Add more words to the quote from the actual Go documentation (rust-lang/book#1960)
- Remove unused import in lfp (rust-lang/book#1944)
- A small typo? (rust-lang/book#1931)
- Make the code not compile to match the text (rust-lang/book#1926)
- Ferris does-not-compile added (ch9.2) (rust-lang/book#1925)
- ch07 - remove note regarding use and relative path (rust-lang/book#1820)
- tweak opening paragraph of deref coercions (rust-lang/book#1749)

## rust-by-example

9 commits in e76be6b2dc84c6a992e186157efe29d625e29b94..67cfbf31df880728dcf7cb35b15b028ec92caf31
2019-09-03 07:42:26 -0300 to 2019-09-18 09:36:40 -0300
- Fix rust-lang/rust-by-example#90: Add supertraits and Fully Qualified syntax (rust-lang/rust-by-example#1259)
- Fix some broken links. (rust-lang/rust-by-example#1258)
- Fix rust-lang/rust-by-example#1253: Document enum type aliases (rust-lang/rust-by-example#1255)
- Inline code in some new/changed chapters (rust-lang/rust-by-example#1254)
- fix rust-lang/rust-by-example#1067: explain that unit tests can return Result<()> (rust-lang/rust-by-example#1252)
- Fix rust-lang/rust-by-example#1060: add page on Impl Trait (rust-lang/rust-by-example#1251)
- Fix rust-lang/rust-by-example#1053: Added a page about the dyn keyword (rust-lang/rust-by-example#1249)
- Fix rust-lang/rust-by-example#1110: add examples of ? and Option (rust-lang/rust-by-example#1250)
- fix 1037: add the TryFrom chapter back in (rust-lang/rust-by-example#1247)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked on a change we need to make in this repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants