Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Second edition is now the definitive edition #1180

Merged
merged 2 commits into from
Feb 21, 2018
Merged

Second edition is now the definitive edition #1180

merged 2 commits into from
Feb 21, 2018

Conversation

steveklabnik
Copy link
Member

@steveklabnik
Second edition is now the definitive edition
b7f8847 
* Remove warning about draft from second edition
* Add warning about first edition draft being older
* Change overview page to better state today's situation
phil-opp
phil-opp reviewed Feb 21, 2018
View reviewed changes
index.md Outdated

### First Edition

YOu can [read the first edition of "The Rust Programming Language"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: YOu

carols10cents
carols10cents approved these changes Feb 21, 2018
View reviewed changes
Copy link
Member

@carols10cents carols10cents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, built the first and second editions locally and everything looked as i would expect. It's a bit hard to test the rustbuild stuff and the links; could you send a pr to rust to get this into nightly so we can make sure that part works soon?

@carols10cents
Copy link
Member

fancy, trying out leaving the tab open to see if github merges when travis succeeds

@steveklabnik
Copy link
Member Author

could you send a pr to rust to get this into nightly so we can make sure that part works soon?

I was planning on doing it right after the merge :)

@carols10cents carols10cents merged commit f1eb574 into master Feb 21, 2018
@carols10cents carols10cents deleted the second-edition-is-the-best branch February 21, 2018 18:30
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Feb 21, 2018
@steveklabnik
Update the book to promote second edition
ef48e0f 
This updates the book repository, but mostly to include
rust-lang/book#1180

TL;DR: the second edition is close enough to done that we should
universally recommend it over the first edition.
@steveklabnik steveklabnik mentioned this pull request Feb 21, 2018
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 24, 2018
@Manishearth
Rollup merge of rust-lang#48404 - steveklabnik:second-edition-is-the-…
9901bef 
…best-edition, r=QuietMisdreavus

Update the book to promote second edition

This updates the book repository, but mostly to include
rust-lang/book#1180

TL;DR: the second edition is close enough to done that we should
universally recommend it over the first edition.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-opp phil-opp phil-opp left review comments

@carols10cents carols10cents carols10cents approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steveklabnik @carols10cents @phil-opp