Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2018 Edition] Ch. 12.2. - Listing 12-3 poem.txt #1533

Closed
gemuesehai opened this issue Sep 19, 2018 · 5 comments
Closed

[2018 Edition] Ch. 12.2. - Listing 12-3 poem.txt #1533

gemuesehai opened this issue Sep 19, 2018 · 5 comments

Comments

@gemuesehai
Copy link
Contributor

Could be intentional, as the text says to "enter the poem" but when I copy and paste the poem in Listing 12-3 into a poem.txt in Windows the program will panic:

kind: InvalidData, error: StringError("stream did not contain valid UTF-8")

This is fixed by removing all instances of ’ and the —

@carols10cents
Copy link
Member

This was previously reported and fixed in the second edition. @steveklabnik does this fix just need to be copied over to the 2018 edition?

@steveklabnik
Copy link
Member

steveklabnik commented Sep 19, 2018 via email

@gemuesehai
Copy link
Contributor Author

I created a pull request (#1588) with the changes. I hope this is the right way to do this. I am new to this so please let me know if I did something wrong.

@steveklabnik
Copy link
Member

Not at all! I won't have time to look until Monday or Tuesday though, so please forgive me!

@carols10cents
Copy link
Member

Your pull request is perfect! I've merged it in, thank you!

carols10cents added a commit that referenced this issue Mar 1, 2021
This isn't always recognized as UTF-8 on all platforms after
copy-pasting.

Fixes #2606
Related to #2539, #1307, #1533
joeljpresent pushed a commit to joeljpresent/rust-book-fr that referenced this issue Apr 13, 2021
This isn't always recognized as UTF-8 on all platforms after
copy-pasting.

Fixes rust-lang#2606
Related to rust-lang#2539, rust-lang#1307, rust-lang#1533
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants