-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2018 Edition] Ch. 12.2. - Listing 12-3 poem.txt #1533
Comments
This was previously reported and fixed in the second edition. @steveklabnik does this fix just need to be copied over to the 2018 edition? |
I thought I did, but let's leave it open to remind me to check.
…On Wed, Sep 19, 2018 at 12:58 PM Carol (Nichols || Goulding) < ***@***.***> wrote:
This was previously reported
<#1307> and fixed in the second
edition
<74a66e1>.
@steveklabnik <https://github.com/steveklabnik> does this fix just need
to be copied over to the 2018 edition?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1533 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABsit8ic1SeYTZbAKuW65-aJUAFUflfks5ucneYgaJpZM4Wwc-q>
.
|
I created a pull request (#1588) with the changes. I hope this is the right way to do this. I am new to this so please let me know if I did something wrong. |
Not at all! I won't have time to look until Monday or Tuesday though, so please forgive me! |
Your pull request is perfect! I've merged it in, thank you! |
This isn't always recognized as UTF-8 on all platforms after copy-pasting. Fixes rust-lang#2606 Related to rust-lang#2539, rust-lang#1307, rust-lang#1533
Could be intentional, as the text says to "enter the poem" but when I copy and paste the poem in Listing 12-3 into a poem.txt in Windows the program will panic:
This is fixed by removing all instances of ’ and the —
The text was updated successfully, but these errors were encountered: