Skip to content

next-solver enable by default - #1896

Merged
lqd merged 1 commit into
rust-lang:mainfrom
lcnr:next-solver-enable-by-default
Aug 21, 2026
Merged

lqd merged 1 commit into
rust-lang:mainfrom
lcnr:next-solver-enable-by-default

Conversation

@lcnr

@lcnr lcnr commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Should get merged together with rust-lang/rust#160619

cc @rust-lang/types @rust-lang/initiative-trait-system-refactor

Rendered

Comment thread content/next-solver-enabled-on-nightly.md Outdated

@Kobzol Kobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Should the blog post mention a way to opt-out? Some people might want to use nightly, but not the next trait solver, if they run into any issues.

View changes since this review

Comment thread content/next-solver-enabled-on-nightly.md Outdated
Comment thread content/next-solver-enabled-on-nightly.md Outdated
Comment thread content/next-solver-enabled-on-nightly.md Outdated

@pthariensflame pthariensflame left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some grammar/style/flow nits; no semantic changes. This was done entirely through our human brain and hands, without tool assistance of LLM-kind or any other.

View changes since this review

Comment thread content/stabilizing-the-next-solver-trait-solver.md Outdated
Comment thread content/stabilizing-the-next-solver-trait-solver.md Outdated
Comment thread content/stabilizing-the-next-solver-trait-solver.md Outdated
Comment thread content/stabilizing-the-next-solver-trait-solver.md Outdated
Comment thread content/stabilizing-the-next-solver-trait-solver.md Outdated
Comment thread content/stabilizing-the-next-solver-trait-solver.md Outdated
Comment thread content/stabilizing-the-next-solver-trait-solver.md Outdated
Comment thread content/stabilizing-the-next-solver-trait-solver.md Outdated
Comment thread content/stabilizing-the-next-solver-trait-solver.md Outdated
Comment thread content/stabilizing-the-next-solver-trait-solver.md Outdated
@lcnr
lcnr force-pushed the next-solver-enable-by-default branch from 0c11ed5 to 2a7074b Compare August 12, 2026 12:05
@lcnr

lcnr commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

Will actually publish this together with it actually being enabled by default, so reworded it slightly, performance and breakage is also in a far better spot than I originally thought, so I adapted the framing somewhat, still need to write the second half

@pthariensflame pthariensflame left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another spelling/grammar/style pass like the previous.

View changes since this review

Comment thread content/enabling-next-solver-on-nightly/index.md Outdated
Comment thread content/enabling-next-solver-on-nightly/index.md Outdated
Comment thread content/enabling-next-solver-on-nightly/index.md Outdated
Comment thread content/enabling-next-solver-on-nightly/index.md Outdated
Comment thread content/enabling-next-solver-on-nightly/index.md Outdated
Comment thread content/enabling-next-solver-on-nightly/index.md Outdated
Comment thread content/enabling-next-solver-on-nightly/index.md Outdated
@lcnr
lcnr marked this pull request as ready for review August 18, 2026 13:16
@lcnr
lcnr force-pushed the next-solver-enable-by-default branch from d2ec705 to e551c39 Compare August 18, 2026 14:10
rust-bors Bot pushed a commit to rust-lang/rust that referenced this pull request Aug 20, 2026
Enable `-Znext-solver` on nightly by default



Implementation of rust-lang/compiler-team#1014 cc rust-lang/blog.rust-lang.org#1896 #160895

This enables `-Znext-solver=globally` by default in nightly, but keeps `-Znext-solver=coherence` for tests
rust-bors Bot pushed a commit to rust-lang/rust that referenced this pull request Aug 21, 2026
…nn,kobzol

Enable `-Znext-solver` on nightly by default



Implementation of rust-lang/compiler-team#1014 cc rust-lang/blog.rust-lang.org#1896 #160895

This enables `-Znext-solver=globally` by default in nightly, but keeps `-Znext-solver=coherence` for most tests.
@theemathas

Copy link
Copy Markdown
Contributor

I assume this can be merged, now that rust-lang/rust#160619 has merged?

@lcnr
lcnr force-pushed the next-solver-enable-by-default branch from f7ca3c1 to 38dce5b Compare August 21, 2026 14:24
@Kobzol

Kobzol commented Aug 21, 2026

Copy link
Copy Markdown
Member

Just noting that the blog post says that it has already been enabled, but it will only be enabled from tomorrow's nightly. So if it is merged until then, it won't be accurate and people might get a bit confused if they read it in the next couple of hours.

@Kivooeo

Kivooeo commented Aug 21, 2026

Copy link
Copy Markdown
Member

we can edit it a bit and say it will be enabled <date>

no rush though, im fine with wait a day before release a post

Comment thread content/enabling-next-solver-on-nightly/index.md Outdated
@Kobzol

Kobzol commented Aug 21, 2026

Copy link
Copy Markdown
Member

Sorry to be a buzzkill, but "tomorrow" is not a good date to have in a blog post xD (unless you would modify the blog post later) I'd suggest simply saying that it will be available on the nightly channel starting from Saturday 22nd August. It can still be confusing w.r.t. timezones and the fact that there are two dates involved with each nightly, but at least it won't be relative to whenever the reader reads the blog post 😆

@lqd

lqd commented Aug 21, 2026

Copy link
Copy Markdown
Member

let's ship it 🚀

@lcnr

lcnr commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

(unless you would modify the blog post later)

I would modify it once it is available on saturday :>

@lcnr

lcnr commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

⚠️ While the next-generation trait solver has been enabled on our main branch, this change will only be accessible on the nighly channel starting from Saturday 22nd August. You can already test it now by providing -Znext-solver=globally as a command-line argument to the most recent nightly version ⚠️

updated it to that with the expectation that we still remove it tmrw 😁

Comment thread content/enabling-next-solver-on-nightly/index.md Outdated
@lcnr
lcnr force-pushed the next-solver-enable-by-default branch from bad00bd to 4782d80 Compare August 21, 2026 14:51
@lcnr
lcnr force-pushed the next-solver-enable-by-default branch from 4782d80 to 26b2d92 Compare August 21, 2026 14:53

@lqd lqd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Years in the making 🚀

View changes since this review

@lqd

lqd commented Aug 21, 2026

Copy link
Copy Markdown
Member

Merging. If anyone wants more changes: open a PR :3

@lqd
lqd added this pull request to the merge queue Aug 21, 2026
Merged via the queue into rust-lang:main with commit 6f735c6 Aug 21, 2026
7 checks passed
@lcnr
lcnr deleted the next-solver-enable-by-default branch August 21, 2026 15:00
pull Bot pushed a commit to xtqqczze/rust-lang-miri that referenced this pull request Aug 22, 2026
…nn,kobzol

Enable `-Znext-solver` on nightly by default



Implementation of rust-lang/compiler-team#1014 cc rust-lang/blog.rust-lang.org#1896 rust-lang/rust#160895

This enables `-Znext-solver=globally` by default in nightly, but keeps `-Znext-solver=coherence` for most tests.
flip1995 pushed a commit to flip1995/rust that referenced this pull request Aug 23, 2026
…donszelmann,kobzol

Enable `-Znext-solver` on nightly by default



Implementation of rust-lang/compiler-team#1014 cc rust-lang/blog.rust-lang.org#1896 rust-lang#160895

This enables `-Znext-solver=globally` by default in nightly, but keeps `-Znext-solver=coherence` for most tests.
github-actions Bot pushed a commit to rust-lang/stdarch that referenced this pull request Aug 24, 2026
…nn,kobzol

Enable `-Znext-solver` on nightly by default



Implementation of rust-lang/compiler-team#1014 cc rust-lang/blog.rust-lang.org#1896 rust-lang/rust#160895

This enables `-Znext-solver=globally` by default in nightly, but keeps `-Znext-solver=coherence` for most tests.
github-actions Bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Aug 24, 2026
…nn,kobzol

Enable `-Znext-solver` on nightly by default



Implementation of rust-lang/compiler-team#1014 cc rust-lang/blog.rust-lang.org#1896 rust-lang/rust#160895

This enables `-Znext-solver=globally` by default in nightly, but keeps `-Znext-solver=coherence` for most tests.
tgross35 pushed a commit to rust-lang/compiler-builtins that referenced this pull request Aug 31, 2026
…nn,kobzol

Enable `-Znext-solver` on nightly by default



Implementation of rust-lang/compiler-team#1014 cc rust-lang/blog.rust-lang.org#1896 rust-lang/rust#160895

This enables `-Znext-solver=globally` by default in nightly, but keeps `-Znext-solver=coherence` for most tests.
asukaminato0721 pushed a commit to asukaminato0721/rust-analyzer that referenced this pull request Sep 2, 2026
…nn,kobzol

Enable `-Znext-solver` on nightly by default



Implementation of rust-lang/compiler-team#1014 cc rust-lang/blog.rust-lang.org#1896 rust-lang/rust#160895

This enables `-Znext-solver=globally` by default in nightly, but keeps `-Znext-solver=coherence` for most tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants