next-solver enable by default - #1896
Conversation
0c11ed5 to
2a7074b
Compare
|
Will actually publish this together with it actually being enabled by default, so reworded it slightly, performance and breakage is also in a far better spot than I originally thought, so I adapted the framing somewhat, still need to write the second half |
d2ec705 to
e551c39
Compare
Enable `-Znext-solver` on nightly by default Implementation of rust-lang/compiler-team#1014 cc rust-lang/blog.rust-lang.org#1896 #160895 This enables `-Znext-solver=globally` by default in nightly, but keeps `-Znext-solver=coherence` for tests
…nn,kobzol Enable `-Znext-solver` on nightly by default Implementation of rust-lang/compiler-team#1014 cc rust-lang/blog.rust-lang.org#1896 #160895 This enables `-Znext-solver=globally` by default in nightly, but keeps `-Znext-solver=coherence` for most tests.
|
I assume this can be merged, now that rust-lang/rust#160619 has merged? |
f7ca3c1 to
38dce5b
Compare
|
Just noting that the blog post says that it has already been enabled, but it will only be enabled from tomorrow's nightly. So if it is merged until then, it won't be accurate and people might get a bit confused if they read it in the next couple of hours. |
|
we can edit it a bit and say it will be enabled <date> no rush though, im fine with wait a day before release a post |
|
Sorry to be a buzzkill, but "tomorrow" is not a good date to have in a blog post xD (unless you would modify the blog post later) I'd suggest simply saying that it will be available on the nightly channel starting from Saturday 22nd August. It can still be confusing w.r.t. timezones and the fact that there are two dates involved with each nightly, but at least it won't be relative to whenever the reader reads the blog post 😆 |
|
let's ship it 🚀 |
I would modify it once it is available on saturday :> |
updated it to that with the expectation that we still remove it tmrw 😁 |
bad00bd to
4782d80
Compare
4782d80 to
26b2d92
Compare
|
Merging. If anyone wants more changes: open a PR :3 |
…nn,kobzol Enable `-Znext-solver` on nightly by default Implementation of rust-lang/compiler-team#1014 cc rust-lang/blog.rust-lang.org#1896 rust-lang/rust#160895 This enables `-Znext-solver=globally` by default in nightly, but keeps `-Znext-solver=coherence` for most tests.
…donszelmann,kobzol Enable `-Znext-solver` on nightly by default Implementation of rust-lang/compiler-team#1014 cc rust-lang/blog.rust-lang.org#1896 rust-lang#160895 This enables `-Znext-solver=globally` by default in nightly, but keeps `-Znext-solver=coherence` for most tests.
…nn,kobzol Enable `-Znext-solver` on nightly by default Implementation of rust-lang/compiler-team#1014 cc rust-lang/blog.rust-lang.org#1896 rust-lang/rust#160895 This enables `-Znext-solver=globally` by default in nightly, but keeps `-Znext-solver=coherence` for most tests.
…nn,kobzol Enable `-Znext-solver` on nightly by default Implementation of rust-lang/compiler-team#1014 cc rust-lang/blog.rust-lang.org#1896 rust-lang/rust#160895 This enables `-Znext-solver=globally` by default in nightly, but keeps `-Znext-solver=coherence` for most tests.
…nn,kobzol Enable `-Znext-solver` on nightly by default Implementation of rust-lang/compiler-team#1014 cc rust-lang/blog.rust-lang.org#1896 rust-lang/rust#160895 This enables `-Znext-solver=globally` by default in nightly, but keeps `-Znext-solver=coherence` for most tests.
…nn,kobzol Enable `-Znext-solver` on nightly by default Implementation of rust-lang/compiler-team#1014 cc rust-lang/blog.rust-lang.org#1896 rust-lang/rust#160895 This enables `-Znext-solver=globally` by default in nightly, but keeps `-Znext-solver=coherence` for most tests.
Should get merged together with rust-lang/rust#160619
cc @rust-lang/types @rust-lang/initiative-trait-system-refactor
Rendered