-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blog post re ctfe ub change observed in 1.64. #1028
Conversation
I am thinking this ought to go on the main blog, rather than Inside Rust; it feels aimed at average users more so than rust project developers. I'll echo commentary from Zulip around "why is that flag not the default"; I think we might want to give an answer there. |
I had internally debated about where it should go. In some ways, I chose "Inside Rust" because I didn't want to cause undue alarm amongst our users. But this feedback has pushed me back over the other direction; I think I can trust our users to take the time to understand what this post is saying.
Yep, I'll add that in as well. (As well as noting that maybe it will be turned on by default in the future, if we determine that the performance cost is sufficently low.) |
posts/inside-rust/2022-09-14-const-eval-safety-rule-revision.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2022-09-14-const-eval-safety-rule-revision.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Wesley Wiser <[email protected]>
…e is unsafe code during const-eval.
Okay hopefully I can now say I'm done wordsmithing here. :) (Oh, and I changed the file name to 2022-09-15, since I figure this is unlikely to get pushed to the Rust blog as soon as tomorrow. The filename I chose may be wishful thinking, but we do want the post published well before the 1.64.0 release on 2022-09-22) |
…ommand to use to try out the beta. Co-authored-by: Wesley Wiser <[email protected]>
Co-authored-by: Wesley Wiser <[email protected]>
Co-authored-by: Wesley Wiser <[email protected]>
… ...". It wasn't adding anything beyond saying that the status quo might be acceptable, which is already implied by the later text.
…st beta themselves.
…cope of the problem described in this post is limited to the intersection of const-eval and unsafe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me but I'd love if @oli-obk had a chance to review as well!
…d in docs of latter.
Co-authored-by: Wesley Wiser <[email protected]>
oh, just so its clear, Oli did look at an earlier draft of this; their feedback was delivered on zulip (and was what @Mark-Simulacrum was referencing in their comment above). |
This is offshoot of rust-lang/rust#99923 and rust-lang/compiler-team#549