-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't let rustc-dep-of-std enable backtrace-sys #297
Conversation
d94848a
to
eda2e45
Compare
eda2e45
to
0b37a22
Compare
I sort of forget the context for this at this point again, but is this somethign that we can condition the target string on? For example could a new target be added to print out the |
The point of this is to be able to do a cross check build of libstd without the backtrace feature for foreign architectures with only a Rust toolchain. This is needed for rust-lang/miri#1198: since Miri is just an interpreter, in principle we should be able to emulate any target platform on any host platform. Since recently Miri just does check builds for everything, so rust-lang/rust#56443 is not a problem any more. The only thing that still fails when I run libstd without the backtrace feature depends on an "empty" backtrace with no features (you requested that in rust-lang/rust#64444 to avoid lots of
I don't follow... how would we condition the target string on anything? We don't control the target string? |
Ah ok that makes sense, thanks for the explanation! The motivating case looks to be "I disabled backtraces in libstd but backtrace-sys is still getting built when checking for standard platforms", specifically in your cross build case. That's good enough for me at least :) Ah and for conditioning the target string, I thought this was originally motivated by "whenever I build for platform X I want to disable backtraces" which I think is best handled in the code itself, not with more features. That's not the motivation for this, though, so it's all good! |
Yes that's a good summary. :) |
update backtrace crate In particular this release includes rust-lang/backtrace-rs#297 and rust-lang/backtrace-rs#300.
update backtrace crate In particular this release includes rust-lang/backtrace-rs#297 and rust-lang/backtrace-rs#300.
update backtrace crate In particular this release includes rust-lang/backtrace-rs#297 and rust-lang/backtrace-rs#300.
276: skip copy of windows-gnu libs in check-only mode r=RalfJung a=RalfJung Unfortunately we cannot test `--target x86_64-pc-windows-gnu` until rust-lang/backtrace-rs#297 lands and propagates. But I confirmed locally that using both together makes that target work on my Linux box. Co-authored-by: Ralf Jung <[email protected]>
Fixes #253