Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unmaintained spin crate. #178

Closed
wants to merge 2 commits into from
Closed

Remove unmaintained spin crate. #178

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 1, 2020

Close #163.

I chose spinning-rs as a replacement for spin as it is actively maintained and requires few changes to the code base.

Another alternative is spinning_top from rust_osdev, however this doesn't implement Once<T>.

@BurntSushi
Copy link
Member

I'd like to point out that this appears to add two new dependencies to the tree as well, lock_api and scopeguard. The spin crate had no dependencies.

@ghost
Copy link
Author

ghost commented Sep 2, 2020

@BurntSushi We could also write our own Once<T> type, but this would add more to maintain. I will gladly add that implementation if you prefer though.

Edit: lock_api depends on scopeguard, so replacing spin will add another dependency, scopeguard.

@zesterer
Copy link
Contributor

zesterer commented Oct 10, 2020

spin-rs is now maintained again.

@ghost
Copy link
Author

ghost commented Oct 10, 2020

Thanks.

@ghost ghost closed this Oct 10, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spin-rs no longer maintained (dependency)
2 participants