Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add track_caller attr for asser_equal #976

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

l4l
Copy link
Contributor

@l4l l4l commented Jul 30, 2024

Without the attribute the panic location is useless, see playground:

thread 'main' panicked at /playground/.cargo/registry/src/index.crates.io-6f17d22bba15001f/itertools-0.13.0/src/lib.rs:4289:17:
Failed assertion Some(1) == Some(2) for iteration 0

Stable since 1.44: rust-lang/rust#72445

@jswrenn jswrenn added this to the next milestone Jul 30, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.47%. Comparing base (6814180) to head (97d9ecc).
Report is 128 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #976      +/-   ##
==========================================
+ Coverage   94.38%   94.47%   +0.08%     
==========================================
  Files          48       49       +1     
  Lines        6665     6769     +104     
==========================================
+ Hits         6291     6395     +104     
  Misses        374      374              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jswrenn jswrenn added this pull request to the merge queue Oct 22, 2024
Merged via the queue into rust-itertools:master with commit b793238 Oct 22, 2024
13 of 14 checks passed
@l4l l4l deleted the patch-1 branch October 22, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants