-
Notifications
You must be signed in to change notification settings - Fork 337
Fuse the iterator in LazyBuffer
#727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bors
merged 1 commit into
rust-itertools:master
from
Philippe-Cholet:lazy_buffer_size_hint
Aug 16, 2023
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is only used in
Powerset::size_hint, where we ask forsrc().size_hint- I think that using the size_hint of the fused iterator is actually what we want there. Can you confirm this?I guess that
Powerset::size_hintshould - in the future - also redirect toLazyBuffer::size_hint, no? Then we could get rid of thissrcexposing the innards ofLazyBufferentirelyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes entirely, I confirm that
Powerset::size_hintwants the not yet writtenLazyBuffer::size_hintfrom the wrappedCombinations.fn srcmight becomefn pool(&self) -> &LazyBuffer<I>later in order forPowerset::size_hinttolet src_total = self.combs.pool().size_hint();instead of doing the job ofLazyBuffer::size_hint.