-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove linker hack #50
Conversation
Better error message when version of honggfuzz bin and lib do not match
I'll close the PR as ubuntu commonly used in CI currently uses an old version of LLVM. |
Nice! I'll be happy to see this code go :) |
no, it's fine, I'll force the CI to use Ubuntu 20.04, I think it's reasonable to require a 1year old LTS version of ubuntu |
I think it has more to do with the llvm version than with Ubuntu's: https://github.com/rust-fuzz/honggfuzz-rs/runs/2096378570#step:1:4. |
ah yes, they finally changed |
e6d3705
to
f4a7c7e
Compare
I'm back after a little while, but I guess we can now safely remove this hack. |
The hack causes troubles for projects utilizing
wasm32-unknown-unknown
targets as rust uses a custom linkerwasm-lld
for it.I don't see any
__sancov_guards
errors when the hack is removed with the recent version of LLVM.cc rust-lang/rust#53945