Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove linker hack #50

Merged
merged 5 commits into from
Aug 16, 2022
Merged

remove linker hack #50

merged 5 commits into from
Aug 16, 2022

Conversation

ordian
Copy link
Contributor

@ordian ordian commented Mar 12, 2021

The hack causes troubles for projects utilizing wasm32-unknown-unknown targets as rust uses a custom linker wasm-lld for it.

I don't see any __sancov_guards errors when the hack is removed with the recent version of LLVM.

cc rust-lang/rust#53945

@ordian
Copy link
Contributor Author

ordian commented Mar 12, 2021

I'll close the PR as ubuntu commonly used in CI currently uses an old version of LLVM.

@ordian ordian closed this Mar 12, 2021
@PaulGrandperrin
Copy link
Member

Nice! I'll be happy to see this code go :)
I guess the CI is failing because GH Action is still using Ubuntu 18.04 by default, but I tested on my machine which is using 20.04 is it's fine.

@PaulGrandperrin
Copy link
Member

no, it's fine, I'll force the CI to use Ubuntu 20.04, I think it's reasonable to require a 1year old LTS version of ubuntu

@ordian
Copy link
Contributor Author

ordian commented Mar 12, 2021

I think it has more to do with the llvm version than with Ubuntu's: https://github.com/rust-fuzz/honggfuzz-rs/runs/2096378570#step:1:4.

@PaulGrandperrin
Copy link
Member

ah yes, they finally changed ubuntu-latest to 20.04 so yes it isn't that..
it's working on my 20.04 local machine through.. I'm trying to figure out why

@PaulGrandperrin PaulGrandperrin force-pushed the master branch 2 times, most recently from e6d3705 to f4a7c7e Compare August 16, 2022 22:10
@PaulGrandperrin PaulGrandperrin merged commit 9e08bbd into rust-fuzz:master Aug 16, 2022
@PaulGrandperrin
Copy link
Member

I'm back after a little while, but I guess we can now safely remove this hack.
I hope this will solve the issues with wasm! I don't know how to test though..

PaulGrandperrin added a commit that referenced this pull request Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants