You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version 0.2 of the arbitrary crate seems to have changed
some error types so that the current code that is generated by the fuzz!
macro does not compile.
This changes the code to be independent of the errors types and also
adds arbitrary as a re-exported dependency so that its usage is fully
transparent to users of this crate.
The current version 0.2 of the arbitrary crate seems to have changed
some error types so that the current code that is generated by the fuzz!
macro does not compile.
This changes the code to be independent of the errors types and also
adds arbitrary as a re-exported dependency so that its usage is fully
transparent to users of this crate.
15: Adjust for changed error types in arbitrary crate r=PaulGrandperrin a=adam-rhebo
The current version 0.2 of the arbitrary crate seems to have changed
some error types so that the current code that is generated by the fuzz!
macro does not compile.
This changes the code to be independent of the errors types and also
adds arbitrary as a re-exported dependency so that its usage is fully
transparent to users of this crate.
Co-authored-by: Adam Reichold <[email protected]>
@PaulGrandperrin Sorry if I hijack this thread: But I just noticed something when testing this: When I noticed this not working with the current arbitrary, I open-coded the this but used FiniteBuffer instead of RingBuffer to create Vec<Vec<u8>>. The same fuzz target got around 10000 iterations per second with that approach, but running it now using RingBuffer I only get around 100 iterations per second. Could that be because FiniteBuffer just fails to create these vector of vectors when "the numbers don't match" and I now see the real speed without the early returns or is there some fundamental difference to how these work?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ghost
mentioned this pull request
ghost
deleted the
The current version 0.2 of the arbitrary crate seems to have changed
some error types so that the current code that is generated by the fuzz!
macro does not compile.
This changes the code to be independent of the errors types and also
adds arbitrary as a re-exported dependency so that its usage is fully
transparent to users of this crate.