Implement Arbitrary for core::cmp::Reverse #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
approved these changes
Dec 5, 2024
fitzgen
approved these changes
Dec 10, 2024
|
Looks like CI is failing due to an unnecessary lifetime: https://github.com/rust-fuzz/arbitrary/actions/runs/12189632357/job/34005838391?pr=210#step:5:30 |
|
We should probably opt into a specific set of clippy lints, rather than whatever the defaults are, so that as new lints get added in the future our CI doesn't break from under us. |
|
Clippy fix in #211 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a lot of data structures that depend on ordering requirements that we enforce via things like
BTreeMap<Reverse<K>, V>, so havingReverse<T>: Arbitrary where T: Arbitrarywould be very useful for cutting down on a bunch of implementation boilerplate.Edit: currently this fails clippy, but it seems like the failing code is unrelated to my diff, and is probably because of Rust 1.83 changing lint checks for elidable lifetimes.