feat: expose evm internal fns #62

gakonst · 2021-09-28T16:33:30Z

If 3rd parties want to build custom stack executors or stack states, they will need access to the datatypes defined inside this module

also adds auto_impl to implement common traits for Box, Arc, & and &mut variants.

sorpaas · 2021-09-28T17:36:57Z

src/executor/mod.rs

@@ -3,7 +3,7 @@
 //! Executors are structs that hook gasometer and the EVM core together. It
 //! also handles the call stacks in EVM.

-mod stack;
+pub mod stack;

 pub use self::stack::{
 	MemoryStackState, Precompile, PrecompileOutput, StackExecutor, StackExitKind, StackState,


Would you mind to export MemoryStackAccount here instead?

requires using our patch of the upstream evm until rust-ethereum/evm#62 is merged

gakonst · 2021-09-30T11:16:00Z

@sorpaas done. I also added 66a729b because I am trying to hook on some of the EVM's internals downstream here and they were not visible before.

sorpaas · 2021-09-30T12:37:53Z

src/executor/mod.rs

 };
+
+pub use ethereum::Log;


Why this though?

Because of this. Ideally I'd like to avoid having to import ethereum explicitly in my crate and have to manage its version & make sure it's in line with sputnik's.

requires using our patch of the upstream evm until rust-ethereum/evm#62 is merged

gakonst · 2021-09-30T20:19:19Z

@sorpaas I also added bbb1ba1 which is a nice expansion on the types that implement the traits. should be straightforward to review.

* feat: create cheatcode module * feat import MemoryStackState from upstream * feat(memory-stack-state-owned): modify to own the backend type requires using our patch of the upstream evm until rust-ethereum/evm#62 is merged * feat(backend): add cheatcode backend (wrapper around backends) * feat(evm): generalize Sputnik's stack executor to trait This will allow us to instantiate the Sputnik EVM executor with a cheatcode-enabled one * feat(handler): add cheatcode handler to apply cheatcodes dynamically * feat(CheatcodeHandler): first pass at implementing SputnikExecutor * feat: import upstream transact_call * fix: modify transact_call to use newly exposed handler methods * feat: import upstream call_inner * fix: modify `call_inner` to use newly exposed handler methods * feat: enable cheatcode via Solidity * chore: cargo fmt * chore: remove unused tracing and dbg macros * feat: enable roll and warp cheatcodes * chore: upgrade ethers to allow short human readable function sigs * chore: cargo fmt * feat: add helper function for instantiating cheatcode evm * feat(cli): enable cheatcodes * chore: bump deps

gakonst · 2021-10-03T05:32:12Z

Bump!

sorpaas · 2021-10-03T23:51:38Z

Sorry for taking so long. I'll have to add no_std tests first. After that I'll merge this!

gakonst · 2021-10-04T00:53:03Z

Sounds great to me. Thank you!

If 3rd parties want to build custom stack executors or stack states, they will need access to the datatypes defined inside this module

sorpaas · 2021-10-07T00:42:26Z

Let me get the no_std tests later.

src/backend/memory.rs

sorpaas · 2021-10-07T00:47:53Z

Everything else looks good.

gakonst · 2021-10-10T20:08:24Z

@sorpaas I have removed the default impl - anything else I can do to move the PR forward?

sorpaas · 2021-10-10T21:31:21Z

Please fix lints.

zjb0807 · 2021-10-22T01:01:37Z

auto-impl-rs/auto_impl#73

auto_impl not support no_std. Why the PR was merged?

sorpaas · 2021-10-22T05:28:07Z

That's a mistake of mine. I'll revert it.

* feat: create cheatcode module * feat import MemoryStackState from upstream * feat(memory-stack-state-owned): modify to own the backend type requires using our patch of the upstream evm until rust-ethereum/evm#62 is merged * feat(backend): add cheatcode backend (wrapper around backends) * feat(evm): generalize Sputnik's stack executor to trait This will allow us to instantiate the Sputnik EVM executor with a cheatcode-enabled one * feat(handler): add cheatcode handler to apply cheatcodes dynamically * feat(CheatcodeHandler): first pass at implementing SputnikExecutor * feat: import upstream transact_call * fix: modify transact_call to use newly exposed handler methods * feat: import upstream call_inner * fix: modify `call_inner` to use newly exposed handler methods * feat: enable cheatcode via Solidity * chore: cargo fmt * chore: remove unused tracing and dbg macros * feat: enable roll and warp cheatcodes * chore: upgrade ethers to allow short human readable function sigs * chore: cargo fmt * feat: add helper function for instantiating cheatcode evm * feat(cli): enable cheatcodes * chore: bump deps

sorpaas reviewed Sep 28, 2021

View reviewed changes

gakonst added a commit to foundry-rs/foundry that referenced this pull request Sep 30, 2021

feat(memory-stack-state-owned): modify to own the backend type

be92bf9

requires using our patch of the upstream evm until rust-ethereum/evm#62 is merged

gakonst changed the title ~~feat: expose stack module~~ feat: expose evm internal fns Sep 30, 2021

gakonst mentioned this pull request Sep 30, 2021

feat: cheatcodes foundry-rs/foundry#59

Merged

sorpaas reviewed Sep 30, 2021

View reviewed changes

gakonst added a commit to foundry-rs/foundry that referenced this pull request Sep 30, 2021

feat(memory-stack-state-owned): modify to own the backend type

b396153

requires using our patch of the upstream evm until rust-ethereum/evm#62 is merged

gakonst force-pushed the chore/expose-stack-module branch from bbb1ba1 to 8e10066 Compare October 5, 2021 12:53

gakonst mentioned this pull request Oct 5, 2021

feat: implement clone/debug for state structs #61

Closed

gakonst added 8 commits October 5, 2021 18:33

feat: implement clone/debug for state structs

321ba36

feat: expose stack module

b16b8bc

If 3rd parties want to build custom stack executors or stack states, they will need access to the datatypes defined inside this module

feat: expose known_account

f07d194

feat: expose MemoryStackAccount

c797cce

chore: re-export types instead of exposing the stack module

50191c1

feat: expose state access functions

64e6c68

chore: expose ethereum::Log

fcec36c

feat: auto-impl Box, Arc, & and &mut where possible for traits

625dccc

gakonst force-pushed the chore/expose-stack-module branch from 8e10066 to 625dccc Compare October 5, 2021 17:33

feat: expose MemoryBackend::state_mut

ca5ba10

sorpaas reviewed Oct 7, 2021

View reviewed changes

src/backend/memory.rs Outdated Show resolved Hide resolved

chore: remove Default derivation

c732cf0

feat: expose MemoryStackSubstate::logs

cd4b101

chore: fmt

b90fe9d

sorpaas approved these changes Oct 12, 2021

View reviewed changes

sorpaas merged commit 64b6e28 into rust-ethereum:master Oct 12, 2021

gakonst deleted the chore/expose-stack-module branch October 12, 2021 07:37

sorpaas mentioned this pull request Oct 22, 2021

Remove auto_impl #71

Merged

gakonst mentioned this pull request Nov 17, 2021

feat: reintroduce auto-impl #85

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: expose evm internal fns #62

feat: expose evm internal fns #62

gakonst commented Sep 28, 2021 •

edited

Loading

sorpaas Sep 28, 2021

gakonst commented Sep 30, 2021

sorpaas Sep 30, 2021

gakonst Sep 30, 2021 •

edited

Loading

gakonst commented Sep 30, 2021

gakonst commented Oct 3, 2021

sorpaas commented Oct 3, 2021

gakonst commented Oct 4, 2021

sorpaas commented Oct 7, 2021

sorpaas commented Oct 7, 2021

gakonst commented Oct 10, 2021 •

edited

Loading

sorpaas commented Oct 10, 2021

zjb0807 commented Oct 22, 2021

sorpaas commented Oct 22, 2021

feat: expose evm internal fns #62

feat: expose evm internal fns #62

Conversation

gakonst commented Sep 28, 2021 • edited Loading

sorpaas Sep 28, 2021

Choose a reason for hiding this comment

gakonst commented Sep 30, 2021

sorpaas Sep 30, 2021

Choose a reason for hiding this comment

gakonst Sep 30, 2021 • edited Loading

Choose a reason for hiding this comment

gakonst commented Sep 30, 2021

gakonst commented Oct 3, 2021

sorpaas commented Oct 3, 2021

gakonst commented Oct 4, 2021

sorpaas commented Oct 7, 2021

sorpaas commented Oct 7, 2021

gakonst commented Oct 10, 2021 • edited Loading

sorpaas commented Oct 10, 2021

zjb0807 commented Oct 22, 2021

sorpaas commented Oct 22, 2021

gakonst commented Sep 28, 2021 •

edited

Loading

gakonst Sep 30, 2021 •

edited

Loading

gakonst commented Oct 10, 2021 •

edited

Loading