Backport fixes and update deps at v5.1#121
Merged
debris merged 6 commits intov5.1.0-backportsfrom Aug 28, 2018
Merged
Conversation
Closed
tomusdrw
approved these changes
Aug 28, 2018
debris
approved these changes
Aug 28, 2018
Contributor
Author
|
Thanks for the review. I will tag this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of https://github.com/paritytech/ethabi/pull/120
Current v5.1 does not work with
parity-ethereum. This back-ports two critical bug fixes for String params (#20eb865) and constant functions. Also bumps theethereum-typesandrustc-hexdependencies.This should become the
v5.1.3tag and published as 5.1.3 to unblock openethereum/parity-ethereum#9410