Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Import from the discovery book #102

Closed
wants to merge 1 commit into from
Closed

[WIP] Import from the discovery book #102

wants to merge 1 commit into from

Conversation

jamesmunns
Copy link
Member

Work in Progress/Do Not Merge (yet)

Will require licensing approval from @japaric before merging (CC-BY to CC-BY-SA)

@japaric
Copy link
Member

japaric commented Jun 19, 2018

Will require licensing approval from @japaric before merging (CC-BY to CC-BY-SA)

I agree to re-license the text under the CC-BY-SA license.

@japaric
Copy link
Member

japaric commented Jun 19, 2018

Some notes:

  • The Discovery will be updated shortly to work with the latest version of cortex-m-rt et al.; this PR may need to be updated. I'll drop a comment here once that's done.

  • Let's add a comment to both the embedded book and the discovery book mentioning the other and noting who the target audience of each book is.

@japaric
Copy link
Member

japaric commented Jun 29, 2018

BTW, I updated the Discovery book to work with the latest version of the cortex-m crates in rust-embedded/discovery#86. I'll leave some inline comments about what needs to be changed.

japaric
japaric reviewed Jun 29, 2018
View reviewed changes
books/embedded-rust-book/src/intro/install.md
should work but we have listed the version we have tested.

- Cargo & `rustc` >= nightly-2018-04-08
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The minimal version required is now nightly-2018-06-04.

japaric
japaric reviewed Jun 29, 2018
View reviewed changes
books/embedded-rust-book/src/intro/install.md
- OpenOCD >=0.8. Tested versions: v0.9.0 and v0.10.0

- `arm-none-eabi-ld`. Tested version: 2.30
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now require the whole toolchain: arm-none-eabi-gcc and arm-none-eabi-binutils.

japaric
japaric reviewed Jun 29, 2018
View reviewed changes
books/embedded-rust-book/src/intro/install.md
```

**NOTE** Make sure you have a nightly newer than `nightly-2018-04-08`. `rustc -V` should return a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be updated.

japaric
japaric reviewed Jun 29, 2018
View reviewed changes
books/embedded-rust-book/src/intro/install/linux.md

``` console
$ sudo apt-get install \
binutils-arm-none-eabi \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be gcc-arm-none-eabi

japaric
japaric reviewed Jun 29, 2018
View reviewed changes
books/embedded-rust-book/src/intro/install/linux.md

``` console
$ sudo dnf install \
arm-none-eabi-binutils-cs \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be arm-none-eabi-gcc-cs

japaric
japaric reviewed Jun 29, 2018
View reviewed changes
books/embedded-rust-book/src/intro/install/linux.md

``` console
$ sudo pacman -S \
arm-none-eabi-binutils \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be arm-none-eabi-gcc

japaric
japaric reviewed Jun 29, 2018
View reviewed changes
books/embedded-rust-book/src/intro/install.md
``` console
$ rustc -V
rustc 1.27.0-nightly (056f589fb 2018-04-07)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be rustc 1.28.0-nightly (29f48ccf3 2018-06-03)

@jamesmunns jamesmunns closed this Jul 29, 2018
jamesmunns added a commit that referenced this pull request Jul 29, 2018
@jamesmunns
This commits updates the outline as per issue #115, and superceded PR #…
a1dfa14 
…102
@jamesmunns jamesmunns mentioned this pull request Jul 29, 2018
Merged
@jamesmunns jamesmunns deleted the discovery-import branch August 12, 2018 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@japaric japaric japaric left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesmunns @japaric