Skip to content

Remove useless Variant, use Option instead #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 1, 2021
Merged

Remove useless Variant, use Option instead #496

merged 4 commits into from
Apr 1, 2021

Conversation

@burrbull
Copy link
Member

As each FieldReader now has bits method, I think it is not an issue.

@burrbull burrbull requested a review from a team as a code owner March 27, 2021 16:05
@burrbull burrbull closed this Mar 27, 2021
@burrbull burrbull reopened this Mar 27, 2021
@burrbull burrbull mentioned this pull request Mar 27, 2021
Closed
therealprof
therealprof previously requested changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using Option makes a lot of sense and lets us profit from upstream optimisations and methods which is a good thing. Would you mind removing the u8 change from this PR so we can get that merged?

@burrbull
Copy link
Member Author

Using Option makes a lot of sense and lets us profit from upstream optimisations and methods which is a good thing. Would you mind removing the u8 change from this PR so we can get that merged?

Done.

adamgreig
adamgreig approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors
Copy link
Contributor

bors bot commented Apr 1, 2021

👎 Rejected by code reviews

@adamgreig
Copy link
Member

bors merge

@bors
Copy link
Contributor

bors bot commented Apr 1, 2021

Build succeeded:

@bors bors bot merged commit ab2c67f into master Apr 1, 2021
@bors bors bot deleted the option branch April 1, 2021 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamgreig adamgreig adamgreig approved these changes

@therealprof therealprof therealprof left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@burrbull @adamgreig @therealprof