Skip to content

Only use cortex-m when target is cortex-m. Fixes #482. #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2020
Merged

Only use cortex-m when target is cortex-m. Fixes #482. #483

merged 1 commit into from
Dec 3, 2020

Conversation

@adamgreig
Copy link
Member

There might be more we can do here but this simple fix should at least stop us using cortex-m for targets other than cortex-m.

cc @Rahix

@adamgreig adamgreig requested a review from a team as a code owner December 2, 2020 00:38
@rust-highfive
Copy link

r? @Emilgardis

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Dec 2, 2020
Rahix
Rahix approved these changes Dec 2, 2020
View reviewed changes
Copy link

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the AVR build work again, thanks!

I agree, the large amount of nested branching in this function should probably be refactored at some point in the future ...

therealprof
therealprof approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for picking this up @adamgreig.

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 3, 2020

Build succeeded:

@bors bors bot merged commit 56be787 into master Dec 3, 2020
@bors bors bot deleted the fix-482 branch December 3, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@therealprof therealprof therealprof approved these changes

+1 more reviewer

@Rahix Rahix Rahix approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Emilgardis Emilgardis

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@adamgreig @rust-highfive @therealprof @Rahix @Emilgardis