Deduplicate some code and move some out of the inner loop #423
Conversation
Signed-off-by: Daniel Egger <[email protected]>
|
r? @Disasm (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
S-waiting-on-review
| let quotedfield = String::from("`") + &f.name + "`"; | ||
| let readerdoc = String::from("Reader of field ") + "edfield; |
There was a problem hiding this comment.
Maybe it's better to have just one line for this. Is the performance impact significant compared to format!()?
There was a problem hiding this comment.
core::fmt::write makes up 17.5% of all CPU cycles used in svd2rust so I'm looking for ways to reduce its usage in addition to trying to have canned code available instead of regenerating everything with every invocation.
There was a problem hiding this comment.
I think this code is not faster.
There was a problem hiding this comment.
It's completely in the noise.
There was a problem hiding this comment.
What about merging into one line? It looks more readable and should be (insignificantly) faster:
let readerdoc = String::from("Reader of field `") + &f.name + "`";If you prefer to leave things as they are, just bors r= me
There was a problem hiding this comment.
I have other plans with the quoted field name. ;) Moving out the readerdoc was just to get rid of the three separate definitions.
Still working on figuring out how to make proc_macro2 play ball with respect to being able to pre-generate the TokenTrees/TokenStreams and simply change the field names
423: Deduplicate some code and move some out of the inner loop r=Disasm a=therealprof Signed-off-by: Daniel Egger <[email protected]> Co-authored-by: Daniel Egger <[email protected]>
Build succeeded |
4 participants
Signed-off-by: Daniel Egger [email protected]