Skip to content

simplify enum derive #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 1, 2020
Merged

simplify enum derive #381

merged 1 commit into from
Jan 1, 2020

Conversation

burrbull
Copy link
Member

r? @therealprof

IMPORTANT. Requires Rust 1.37

@burrbull burrbull requested a review from a team as a code owner August 17, 2019 04:19
@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Aug 17, 2019
@therealprof
Copy link
Contributor

IMPORTANT. Requires Rust 1.37

I don't think bumping the MSRV is acceptable. At the very least this would require a discussion and vote.

@burrbull
Copy link
Member Author

I know. It is low priority PR. Add do-not-merge if you can.

@therealprof therealprof added needs-decision S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work. labels Aug 24, 2019
@burrbull burrbull mentioned this pull request Nov 16, 2019
Merged
@burrbull
Copy link
Member Author

burrbull commented Jan 1, 2020

bors try

bors bot added a commit that referenced this pull request Jan 1, 2020
@bors
Try #381:
5c1656d
@bors
Copy link
Contributor

bors bot commented Jan 1, 2020

try

Build failed

@burrbull
Copy link
Member Author

burrbull commented Jan 1, 2020

bors try

@therealprof therealprof removed S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work. needs-decision labels Jan 1, 2020
@burrbull burrbull mentioned this pull request Jan 1, 2020
Merged
bors bot added a commit that referenced this pull request Jan 1, 2020
@bors
Try #381:
eb728dd
@burrbull burrbull mentioned this pull request Jan 1, 2020
Closed
@bors
Copy link
Contributor

bors bot commented Jan 1, 2020

try

Build failed

@burrbull
Copy link
Member Author

burrbull commented Jan 1, 2020

bors try

bors bot added a commit that referenced this pull request Jan 1, 2020
@bors
Try #381:
af7d45b
@bors
Copy link
Contributor

bors bot commented Jan 1, 2020

try

Build succeeded

And happy new year from bors! 🎉

therealprof
therealprof approved these changes Jan 1, 2020
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@therealprof
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Jan 1, 2020
@bors @burrbull
Merge #381
ab03e5e 
381: simplify enum derive r=therealprof a=burrbull

r? @therealprof 

IMPORTANT. Requires [Rust 1.37](https://blog.rust-lang.org/2019/08/15/Rust-1.37.0.html#referring-to-enum-variants-through-type-aliases)

Co-authored-by: Andrey Zgarbul <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jan 1, 2020

Build succeeded

And happy new year from bors! 🎉

@bors bors bot merged commit 0338f9d into rust-embedded:master Jan 1, 2020
@burrbull burrbull deleted the enum-derive branch January 1, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@therealprof therealprof therealprof approved these changes

Assignees

@therealprof therealprof

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@burrbull @therealprof @rust-highfive