Skip to content

Conversation

@burrbull
Copy link
Member

@burrbull burrbull commented Nov 14, 2019

@burrbull burrbull requested a review from a team as a code owner November 14, 2019 18:28
@burrbull burrbull changed the title use anyhow as Error type instead of failure (experiment) use anyhow as Error type instead of failure Nov 15, 2019
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going away from failure seems like a fine thing to do. Thanks!

@burrbull
Copy link
Member Author

bors r=Emilgardis

bors bot added a commit that referenced this pull request Nov 15, 2019
98: use `anyhow` as Error type instead of `failure` r=Emilgardis a=burrbull

https://crates.io/crates/anyhow + https://crates.io/crates/thiserror

Co-authored-by: Andrey Zgarbul <[email protected]>
@bors
Copy link
Contributor

bors bot commented Nov 15, 2019

Build succeeded

@bors bors bot merged commit 349cce5 into master Nov 15, 2019
@burrbull burrbull deleted the anyhow branch November 15, 2019 16:13
bors bot added a commit to rust-embedded/svd2rust that referenced this pull request Apr 23, 2020
398: `anyhow` Error r=Emilgardis a=burrbull

rust-embedded/svd#98

Co-authored-by: Andrey Zgarbul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants