Device: add all properties except vendorExtensions#44
Closed
codyps wants to merge 1 commit intorust-embedded:masterfrom
Closed
Device: add all properties except vendorExtensions#44codyps wants to merge 1 commit intorust-embedded:masterfrom
codyps wants to merge 1 commit intorust-embedded:masterfrom
Conversation
Author
|
I'm going to close this as I'd prefer #37 and related not be delayed (this change is only useful to me if the ability to write out svds exists, anyhow). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like for
vendorExtensionswe'd need to expose anElement. Thoughts on that in a follow up PR?